[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing u
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2015-12-28 23:34:08
Message-ID: 20151228233408.18086.87864 () mimi ! kde ! org
[Download RAW message or body]
--===============5774195375090768117==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/
-----------------------------------------------------------
(Updated Dez. 28, 2015, 11:34 nachm.)
Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
Changes
-------
* Fix KIdleTime resumingFromIdle
I also removed the default "Quit" option and replaced it with a custom "Hide" option, \
or else you get a "Do you really want to quit drkonqi?" message
Repository: plasma-workspace
Description
-------
This adds a new "--passive" option to DrKonqi where it will only show a \
StatusNotifierItem rather than bringing up the crash dialog right away.
This can be useful for auto-restarting shell services (like plasmashell, krunner, \
kded) to improve the perceived quality of the product.
On Windows RT, for example, the guidelines even explicitly say "rather just dump the \
user on the home screen than telling him something went wrong, so he can just quickly \
start the app again instead of being annoyed by an error message". On iOS you also \
just get dropped on the home screen. Windows desktop shows a "Searching for a \
solution" dialog which was *the* major annoyance when something crashed, rather than \
the actual crash.
Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
Diffs (updated)
-----
drkonqi/CMakeLists.txt eaeaad4
drkonqi/main.cpp 7cbaae7
drkonqi/statusnotifier.h PRE-CREATION
drkonqi/statusnotifier.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/126515/diff/
Testing
-------
I crashed plasmashell, it restarted so fast that you didn't even have a black screen \
inbetween, just the panel restarting. Afterwards I got a SNI which opened DrKonqi \
when tapped.
The SNI disappears after 1 minute because if you didn't bother to look after it by \
then, you probably forgot what you did to cause the crash anyway :)
Thanks,
Kai Uwe Broulik
--===============5774195375090768117==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126515/">https://git.reviewboard.kde.org/r/126515/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Plasma, KDE Usability, and Martin \
Gräßlin.</div> <div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Dez. 28, 2015, 11:34 nachm.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* Fix KIdleTime resumingFromIdle
I also removed the default "Quit" option and replaced it with a custom \
"Hide" option, or else you get a "Do you really want to quit \
drkonqi?" message</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This adds a new "--passive" option to DrKonqi where it \
will only show a StatusNotifierItem rather than bringing up the crash dialog right \
away.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This can be useful for auto-restarting shell services \
(like plasmashell, krunner, kded) to improve the perceived quality of the \
product.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On Windows RT, for example, the guidelines even \
explicitly say "rather just dump the user on the home screen than telling him \
something went wrong, so he can just quickly start the app again instead of being \
annoyed by an error message". On iOS you also just get dropped on the home screen. \
Windows desktop shows a "Searching for a solution" dialog which was <em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">the</em> major annoyance when something crashed, rather than the actual \
crash.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Video here: \
https://www.youtube.com/watch?v=t0ZLs-juYKc</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I crashed plasmashell, it restarted so fast that you \
didn't even have a black screen inbetween, just the panel restarting. Afterwards I \
got a SNI which opened DrKonqi when tapped.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The SNI disappears \
after 1 minute because if you didn't bother to look after it by then, you probably \
forgot what you did to cause the crash anyway :)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>drkonqi/CMakeLists.txt <span style="color: grey">(eaeaad4)</span></li>
<li>drkonqi/main.cpp <span style="color: grey">(7cbaae7)</span></li>
<li>drkonqi/statusnotifier.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>drkonqi/statusnotifier.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126515/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5774195375090768117==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic