[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126544: [Kickoff] Hide history tab if empty
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2015-12-28 20:58:01
Message-ID: 20151228205801.18086.76978 () mimi ! kde ! org
[Download RAW message or body]
--===============3319455127399017714==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dez. 28, 2015, 2:02 nachm., Aleix Pol Gonzalez wrote:
> > Maybe show it as disabled at least? It's weird that UI structure change every now \
> > and then.
>
> Heiko Tietze wrote:
> I agree with the idea to avoid changing UI structure. However, to disable isn't \
> good for tabs.
> Here is what we wrote in the tabcontrol HIG:
> * Do not disable a tab when it doesn't apply to the current context; disable the \
> controls on the page.
> * Make tabs closable if their pages contain documents, but not if their pages \
> contain application's user interface.
> -> I recommend to neither hide nor deaktivate the tab.
>
> Eike Hein wrote:
> I generally agree with Heiko here: Major UI elements appearing/disappearing \
> conditionally is usually bad because it's jarring and missing an opportunity to \
> teach the user what functionality they can expect to become available if they do \
> certain things.
> It's a bit different here because the pitch is that the user can disable history \
> tracking and then gets stuck with a guaranteed-to-be-empty tab they might want to \
> get rid of. But I suggest this relationship then needs to be explicit: Disabling \
> history tracking hides the tab. Not to make it magic based on the count in the \
> model.
makes sense. perhaps we should add a text saying that there are currently no recent \
documents / apps, perhaps with a button to open activity (tracking) settings, even. I \
guess we can query whether tracking is disabled and only then hide the tab.
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126544/#review90210
-----------------------------------------------------------
On Dez. 28, 2015, 8:56 nachm., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126544/
> -----------------------------------------------------------
>
> (Updated Dez. 28, 2015, 8:56 nachm.)
>
>
> Review request for Plasma, KDE Usability and Eike Hein.
>
>
> Bugs: 347633
> https://bugs.kde.org/show_bug.cgi?id=347633
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> This hides the "History" tab if it is empty.
>
> This can permanently happen if you use disable tracking in activity settings or \
> administrative means.
>
> Diffs
> -----
>
> applets/kickoff/package/contents/ui/FavoritesView.qml 5b7a2cf
> applets/kickoff/package/contents/ui/FullRepresentation.qml c2f5ad8
> applets/kickoff/package/contents/ui/RecentlyUsedView.qml 7169622
>
> Diff: https://git.reviewboard.kde.org/r/126544/diff/
>
>
> Testing
> -------
>
> Button comes and goes as I add and remove history entries.
>
> When I clear the history, it switches to the Favorites view so you don't end up \
> with a broken view.
> It doesn't seem to track application launches through Kickoff but I think this is \
> unrelated.
>
> File Attachments
> ----------------
>
> No history tab
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/3f2f0697-b5ce-420a-bfc9-8e949b345439__hiddenhistory.jpg
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============3319455127399017714==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126544/">https://git.reviewboard.kde.org/r/126544/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Dezember 28th, 2015, 2:02 nachm. UTC, <b>Aleix \
Pol Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Maybe show it as disabled at least? It's weird that UI \
structure change every now and then.</p></pre> </blockquote>
<p>On Dezember 28th, 2015, 8:04 nachm. UTC, <b>Heiko Tietze</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
agree with the idea to avoid changing UI structure. However, to disable isn't good \
for tabs.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Here is what we wrote in the tabcontrol HIG: <em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;"> Do not disable a tab when it doesn't apply to the current context; disable \
the controls on the page. </em> Make tabs closable if their pages contain documents, \
but not if their pages contain application's user interface.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">-> \
I recommend to neither hide nor deaktivate the tab.</p></pre> </blockquote>
<p>On Dezember 28th, 2015, 8:22 nachm. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
generally agree with Heiko here: Major UI elements appearing/disappearing \
conditionally is usually bad because it's jarring and missing an opportunity to teach \
the user what functionality they can expect to become available if they do certain \
things.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It's a bit different here because the pitch is that \
the user can disable history tracking and then gets stuck with a \
guaranteed-to-be-empty tab they might want to get rid of. But I suggest this \
relationship then needs to be explicit: Disabling history tracking hides the tab. Not \
to make it magic based on the count in the model.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">makes \
sense. perhaps we should add a text saying that there are currently no recent \
documents / apps, perhaps with a button to open activity (tracking) settings, even. I \
guess we can query whether tracking is disabled and only then hide the tab.</p></pre> \
<br />
<p>- Kai Uwe</p>
<br />
<p>On Dezember 28th, 2015, 8:56 nachm. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, KDE Usability and Eike Hein.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Dez. 28, 2015, 8:56 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=347633">347633</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This hides the "History" tab if it is empty.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This can permanently happen if you use disable tracking in activity \
settings or administrative means.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Button comes and goes as I add and remove history \
entries.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When I clear the history, it switches to the Favorites \
view so you don't end up with a broken view.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">It doesn't seem to \
track application launches through Kickoff but I think this is unrelated.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kickoff/package/contents/ui/FavoritesView.qml <span style="color: \
grey">(5b7a2cf)</span></li>
<li>applets/kickoff/package/contents/ui/FullRepresentation.qml <span style="color: \
grey">(c2f5ad8)</span></li>
<li>applets/kickoff/package/contents/ui/RecentlyUsedView.qml <span style="color: \
grey">(7169622)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126544/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/3f2f0697-b5ce-420a-bfc9-8e949b345439__hiddenhistory.jpg">No \
history tab</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3319455127399017714==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic