[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper
From: "Ken Vermette" <vermette () gmail ! com>
Date: 2015-12-28 18:50:03
Message-ID: 20151228185003.31824.74760 () mimi ! kde ! org
[Download RAW message or body]
--===============3240855861059136070==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dec. 28, 2015, 9:16 a.m., Marco Martin wrote:
> > so, let's go with the last one? for me +1, any complaints?
I went ahead and shipped; complaints were mostly focused on the intel-glitch-strip, \
outside of that I think we eliminated the glaring objective issues. I don't think \
there's anything meaningful to change which wouldn't result in an entirely different \
wallpaper and a new wave of issues.
On a side note I just wanted to thank everyone with their patience while I stumbled \
through my first formal review process. I'm very glad it was done properly this time, \
and that I got the additional input. If anyone would like to double-check to make \
sure I didn't botch the actual commit, I would appreciate that as well. Also, should \
I just push the blurred version of the wallpaper for the lock/login and splash \
screens, or create a new review request?
Again, thank you everyone. I appreciate the feedback and the patience while I figured \
this out.
- Ken
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126319/#review90192
-----------------------------------------------------------
On Dec. 28, 2015, 5:47 p.m., Ken Vermette wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126319/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 5:47 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: breeze
>
>
> Description
> -------
>
> Attached images directly to request; if this is not the preferred way of attaching \
> large files, please let me know and I'll change methods, perhaps using the VDG \
> share if that's preferred.
> For reference I would like to shift to more "professional" default wallpapers and \
> away from the more organic style of 5.4 and 5.5. Feedback on both general direction \
> or this wallpaper is welcome.
> Note: I will submit splash files later in case of changes to this wallpaper.
>
>
> Diffs
> -----
>
> wallpapers/Next/contents/images/1024x768.png 60e1205
> wallpapers/Next/contents/images/1280x1024.png 36a9130
> wallpapers/Next/contents/images/1280x800.png c33e594
> wallpapers/Next/contents/images/1440x900.png 2c75b54
> wallpapers/Next/contents/images/1600x1200.png 5ddaf72
> wallpapers/Next/contents/images/1638x1024.png a3c7492
> wallpapers/Next/contents/images/1680x1050.png eddc47e
> wallpapers/Next/contents/images/1920x1080.png ab6d950
> wallpapers/Next/contents/images/2560x1440.png 5c78e9d
> wallpapers/Next/contents/images/2560x1600.png eeb08a1
> wallpapers/Next/contents/images/3200x1800.png 7340567
> wallpapers/Next/contents/images/3200x2000.png fd1a62c
> wallpapers/Next/contents/screenshot.png a6d2b7b
>
> Diff: https://git.reviewboard.kde.org/r/126319/diff/
>
>
> Testing
> -------
>
> Dogfooded on several machines and my phone for a couple weeks now, doesn't burn \
> eyes out. Corner isn't as distracting as one might assume, especially once a window \
> is on screen. Got early feedback, adjustments made from origional \
> in order:
> - Re-drew the "circuit/chip" pattern to be less noisy/distracting/cleaner. Adjusted \
> it so details are still seen on lower-res wallpapers.
> - Lightened purple to avoid the "dark void" feeling people have mentioned feeling \
> from 5.5 wallpaper.
> - Fixed minor pixel issues for triangles near edge
> - Adjusted noise, shadows.
>
>
> File Attachments
> ----------------
>
> 1024x768.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/5e9e5db3-c8d4-43ec-8236-da5daa80be85__1024x768.png
> 1280x800.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/41e11bb9-eaef-4eb1-bb4b-c7137becaca0__1280x800.png
> screenshot.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/ee643bd5-8162-4a9b-ae09-df090d4f0b43__screenshot.png
> 1280x1024.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/054536c9-8160-418a-a1c9-c319e1e2b533__1280x1024.png
> 1440x900.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/c4c61ba4-10ea-4d87-9437-7b7e1701eaf7__1440x900.png
> 1600x1200.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/ee746ed5-428d-4423-8e20-d9786b25190f__1600x1200.png
> 1638x1024.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/233a9950-24bd-47b6-8c7a-8f3e6fe707df__1638x1024.png
> 1680x1050.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/4c86e45c-eb10-47fa-b1ff-736bd65918cc__1680x1050.png
> 1920x1080.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/93cc544a-a8a8-4291-91ff-58140ec5ed64__1920x1080.png
> 2560x1440.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/73ad5caf-5156-495b-939c-387ce4970140__2560x1440.png
> 2560x1600.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/1ff471aa-2e26-41d9-8921-2c62544d3415__2560x1600.png
> 3200x1800.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/7590da34-e5c5-4f55-9ac9-0a22c13a9c0d__3200x1800.png
> 3200x2000.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/229a429e-9633-4988-ad78-dfb039583fc4__3200x2000.png
> desktopWallpaper-graphite-3.3-kvermette.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/27/bc1de0b2-a753-4772-b5a7-8d5c27c0138b__desktopWallpaper-graphite-3.3-kvermette.png
>
>
> Thanks,
>
> Ken Vermette
>
>
--===============3240855861059136070==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126319/">https://git.reviewboard.kde.org/r/126319/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 28th, 2015, 9:16 a.m. UTC, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">so, let's go with the last one? for me +1, any \
complaints?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
went ahead and shipped; complaints were mostly focused on the intel-glitch-strip, \
outside of that I think we eliminated the glaring objective issues. I don't think \
there's anything meaningful to change which wouldn't result in an entirely different \
wallpaper and a new wave of issues.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">On a side note I just \
wanted to thank everyone with their patience while I stumbled through my first formal \
review process. I'm very glad it was done properly this time, and that I got the \
additional input. If anyone would like to double-check to make sure I didn't botch \
the actual commit, I would appreciate that as well. Also, should I just push the \
blurred version of the wallpaper for the lock/login and splash screens, or create a \
new review request?</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Again, thank you everyone. I appreciate \
the feedback and the patience while I figured this out.</p></pre> <br />
<p>- Ken</p>
<br />
<p>On December 28th, 2015, 5:47 p.m. UTC, Ken Vermette wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Ken Vermette.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2015, 5:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Attached images directly to request; if this is not \
the preferred way of attaching large files, please let me know and I'll change \
methods, perhaps using the VDG share if that's preferred.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For \
reference I would like to shift to more "professional" default wallpapers and away \
from the more organic style of 5.4 and 5.5. Feedback on both general direction or \
this wallpaper is welcome.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Note: I will submit splash files later \
in case of changes to this wallpaper.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Dogfooded on several machines and my phone for a \
couple weeks now, doesn't burn eyes out. Corner isn't as distracting as one might \
assume, especially once a window is on screen. Got early feedback, adjustments made \
from origional in order:
- Re-drew the "circuit/chip" pattern to be less noisy/distracting/cleaner. Adjusted \
it so details are still seen on lower-res wallpapers.
- Lightened purple to avoid the "dark void" feeling people have mentioned feeling \
from 5.5 wallpaper.
- Fixed minor pixel issues for triangles near edge
- Adjusted noise, shadows.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>wallpapers/Next/contents/images/1024x768.png <span style="color: \
grey">(60e1205)</span></li>
<li>wallpapers/Next/contents/images/1280x1024.png <span style="color: \
grey">(36a9130)</span></li>
<li>wallpapers/Next/contents/images/1280x800.png <span style="color: \
grey">(c33e594)</span></li>
<li>wallpapers/Next/contents/images/1440x900.png <span style="color: \
grey">(2c75b54)</span></li>
<li>wallpapers/Next/contents/images/1600x1200.png <span style="color: \
grey">(5ddaf72)</span></li>
<li>wallpapers/Next/contents/images/1638x1024.png <span style="color: \
grey">(a3c7492)</span></li>
<li>wallpapers/Next/contents/images/1680x1050.png <span style="color: \
grey">(eddc47e)</span></li>
<li>wallpapers/Next/contents/images/1920x1080.png <span style="color: \
grey">(ab6d950)</span></li>
<li>wallpapers/Next/contents/images/2560x1440.png <span style="color: \
grey">(5c78e9d)</span></li>
<li>wallpapers/Next/contents/images/2560x1600.png <span style="color: \
grey">(eeb08a1)</span></li>
<li>wallpapers/Next/contents/images/3200x1800.png <span style="color: \
grey">(7340567)</span></li>
<li>wallpapers/Next/contents/images/3200x2000.png <span style="color: \
grey">(fd1a62c)</span></li>
<li>wallpapers/Next/contents/screenshot.png <span style="color: \
grey">(a6d2b7b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126319/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/5e9e5db3-c8d4-43ec-8236-da5daa80be85__1024x768.png">1024x768.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/41e11bb9-eaef-4eb1-bb4b-c7137becaca0__1280x800.png">1280x800.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/ee643bd5-8162-4a9b-ae09-df090d4f0b43__screenshot.png">screenshot.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/054536c9-8160-418a-a1c9-c319e1e2b533__1280x1024.png">1280x1024.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/c4c61ba4-10ea-4d87-9437-7b7e1701eaf7__1440x900.png">1440x900.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/ee746ed5-428d-4423-8e20-d9786b25190f__1600x1200.png">1600x1200.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/233a9950-24bd-47b6-8c7a-8f3e6fe707df__1638x1024.png">1638x1024.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/4c86e45c-eb10-47fa-b1ff-736bd65918cc__1680x1050.png">1680x1050.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/93cc544a-a8a8-4291-91ff-58140ec5ed64__1920x1080.png">1920x1080.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/73ad5caf-5156-495b-939c-387ce4970140__2560x1440.png">2560x1440.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/1ff471aa-2e26-41d9-8921-2c62544d3415__2560x1600.png">2560x1600.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/7590da34-e5c5-4f55-9ac9-0a22c13a9c0d__3200x1800.png">3200x1800.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/229a429e-9633-4988-ad78-dfb039583fc4__3200x2000.png">3200x2000.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/27/bc1de0b2 \
-a753-4772-b5a7-8d5c27c0138b__desktopWallpaper-graphite-3.3-kvermette.png">desktopWallpaper-graphite-3.3-kvermette.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3240855861059136070==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic