[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin
From: "Aditya Dev Sharma" <aditya.sharma15696 () gmail ! com>
Date: 2015-12-28 14:09:44
Message-ID: 20151228140944.18086.404 () mimi ! kde ! org
[Download RAW message or body]
--===============2826627217393016540==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
-----------------------------------------------------------
(Updated Dec. 28, 2015, 2:09 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma, Ashish Bansal and Bhushan Shah.
Changes
-------
Submitted with commit cf570eb71014e517c91f718c02a48b7afaa96418 by Aditya Dev Sharma \
to branch master.
Repository: plasma-mediacenter
Description
-------
Implemented it like the other datasources.
Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . \
handleLastFmNewMedia then calls fetchImage for each newMedia in the newMediaList.
After the image is fetched, gotImage emits the signal imageFetched (from \
mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel.
Diffs
-----
libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe
libs/mediacenter/medialibrary.h 45744c1
libs/mediacenter/lastfmimagefetcher.cpp e005077
libs/mediacenter/lastfmimagefetcher.h ecff37e
libs/mediacenter/CMakeLists.txt 5a13449
datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION
datasources/lastfm/CMakeLists.txt PRE-CREATION
datasources/CMakeLists.txt a7171b7
autotests/lastfmimagefetchertest.cpp abb3fd6
autotests/CMakeLists.txt 04ba1c3
autotests/lastfmimagefetchertest.h eb7cb29
Diff: https://git.reviewboard.kde.org/r/125993/diff/
Testing
-------
Builds 100%.
Works as expected.
Thanks,
Aditya Dev Sharma
--===============2826627217393016540==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125993/">https://git.reviewboard.kde.org/r/125993/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Ashish Bansal and Bhushan Shah.</div>
<div>By Aditya Dev Sharma.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2015, 2:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit cf570eb71014e517c91f718c02a48b7afaa96418 by Aditya \
Dev Sharma to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Implemented it like the other datasources.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . \
handleLastFmNewMedia then calls fetchImage for each newMedia in the newMediaList.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">After the image is fetched, gotImage emits the signal \
imageFetched (from mediaLibrary). This signal is absorbed by signalUpdate in \
PmcMetaDataModel.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds 100%. Works as expected.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/mediacenter/pmcmetadatamodel.cpp <span style="color: \
grey">(2fe6efe)</span></li>
<li>libs/mediacenter/medialibrary.h <span style="color: grey">(45744c1)</span></li>
<li>libs/mediacenter/lastfmimagefetcher.cpp <span style="color: \
grey">(e005077)</span></li>
<li>libs/mediacenter/lastfmimagefetcher.h <span style="color: \
grey">(ecff37e)</span></li>
<li>libs/mediacenter/CMakeLists.txt <span style="color: grey">(5a13449)</span></li>
<li>datasources/lastfm/lastfmimagefetcher.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>datasources/lastfm/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>datasources/CMakeLists.txt <span style="color: grey">(a7171b7)</span></li>
<li>autotests/lastfmimagefetchertest.cpp <span style="color: \
grey">(abb3fd6)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(04ba1c3)</span></li>
<li>autotests/lastfmimagefetchertest.h <span style="color: \
grey">(eb7cb29)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125993/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2826627217393016540==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic