'Re: Review Request 126538: Don't duplicate a tonne of KCrash code'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126538: Don't duplicate a tonne of KCrash code
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2015-12-28 11:37:22
Message-ID: 20151228113722.18086.19660 () mimi ! kde ! org
[Download RAW message or body]

--===============8916898664039291210==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126538/
-----------------------------------------------------------

(Updated Dec. 28, 2015, 11:37 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit 3ff5cdd3cf75c7d9d7edd72d88dd1c440fb1995d by David Edmundson to \
branch master.

Repository: plasma-workspace

Description
-------

KCrash already has auto restart which copies the args and only respawns
n times, resetting if we last longer than m seconds.

Timeouts are sligthly different, but if changes are genuinely needed we can add \
options to KCrash.

Diffs
-----

  shell/main.cpp 54f4bd655efb9364aed66d27b9b10708d1e324c3 
  shell/shellmanager.h 3e1fc0a4b05eec0d2f7a1bc3e8c5cfc8cc7934e2 
  shell/shellmanager.cpp 0a6ac5e4ec2de7616be3af7a8715bd4450e562f0 

Diff: https://git.reviewboard.kde.org/r/126538/diff/

Testing
-------

Ran with -w

killed -s SIGSEGV

windowed version restarted

Thanks,

David Edmundson

--===============8916898664039291210==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126538/">https://git.reviewboard.kde.org/r/126538/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Dec. 28, 2015, 11:37 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 3ff5cdd3cf75c7d9d7edd72d88dd1c440fb1995d by David \
Edmundson to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KCrash already has auto restart which copies the args \
and only respawns n times, resetting if we last longer than m seconds.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Timeouts are sligthly different, but if changes are \
genuinely needed we can add options to KCrash.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ran with -w</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">killed -s SIGSEGV</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">windowed version restarted</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shell/main.cpp <span style="color: \
grey">(54f4bd655efb9364aed66d27b9b10708d1e324c3)</span></li>

 <li>shell/shellmanager.h <span style="color: \
grey">(3e1fc0a4b05eec0d2f7a1bc3e8c5cfc8cc7934e2)</span></li>

 <li>shell/shellmanager.cpp <span style="color: \
grey">(0a6ac5e4ec2de7616be3af7a8715bd4450e562f0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126538/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8916898664039291210==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 