'Re: Review Request 126472: Don't always load the timetracker'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126472: Don't always load the timetracker
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2015-12-27 19:38:18
Message-ID: 20151227193818.18086.74808 () mimi ! kde ! org
[Download RAW message or body]

--===============6881493093490137517==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126472/
-----------------------------------------------------------

(Updated Dec. 27, 2015, 7:38 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks and Plasma.

Changes
-------

Submitted with commit ab135f4e8ed451f4f310732e6f5bc084aff69519 by David Edmundson to \
branch master.

Repository: plasma-framework

Description
-------

Don't always load the timetracker

It has a timer that wakes up every 2 seconds and drains my battery just
simply because I have debug builds. This make it on demand.

Don't track containments twice.
Containments inherit from Applets which also have the same line

Diffs
-----

  src/plasma/corona.cpp 316b225ecafcfa6e0b8b894cfea082046c296238 
  src/plasma/private/applet_p.cpp 511b45119f6d91605f36c8b7073a0b0bb4560e5f 
  src/plasma/private/containment_p.cpp 86d27c43f36b9e1741ab13f8153080fb6b92b321 

Diff: https://git.reviewboard.kde.org/r/126472/diff/

Testing
-------

Thanks,

David Edmundson

--===============6881493093490137517==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126472/">https://git.reviewboard.kde.org/r/126472/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Dec. 27, 2015, 7:38 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit ab135f4e8ed451f4f310732e6f5bc084aff69519 by David \
Edmundson to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Don't always load the timetracker</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">It has a timer that wakes up every 2 seconds and drains my battery just \
simply because I have debug builds. This make it on demand.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Don't \
track containments twice. Containments inherit from Applets which also have the same \
line</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/plasma/corona.cpp <span style="color: \
grey">(316b225ecafcfa6e0b8b894cfea082046c296238)</span></li>

 <li>src/plasma/private/applet_p.cpp <span style="color: \
grey">(511b45119f6d91605f36c8b7073a0b0bb4560e5f)</span></li>

 <li>src/plasma/private/containment_p.cpp <span style="color: \
grey">(86d27c43f36b9e1741ab13f8153080fb6b92b321)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126472/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6881493093490137517==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 