[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing u
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2015-12-27 18:31:16
Message-ID: 20151227183116.18086.54721 () mimi ! kde ! org
[Download RAW message or body]
--===============6474831356375450412==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote:
> > drkonqi/main.cpp, line 159
> > <https://git.reviewboard.kde.org/r/126515/diff/2/?file=426276#file426276line159>
> >
> > and -> or surely?
> >
> > both in code and comments.
The and is correct:
- I never want to show the dialog or a notification when we're passive.
- I want to show the DrKonqi dialog instead of the KPassivePopup fallback in case no \
FDO notification service is available
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90166
-----------------------------------------------------------
On Dez. 27, 2015, 4:11 nachm., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> -----------------------------------------------------------
>
> (Updated Dez. 27, 2015, 4:11 nachm.)
>
>
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This adds a new "--passive" option to DrKonqi where it will only show a \
> StatusNotifierItem rather than bringing up the crash dialog right away.
> This can be useful for auto-restarting shell services (like plasmashell, krunner, \
> kded) to improve the perceived quality of the product.
> On Windows RT, for example, the guidelines even explicitly say "rather just dump \
> the user on the home screen than telling him something went wrong, so he can just \
> quickly start the app again instead of being annoyed by an error message". On iOS \
> you also just get dropped on the home screen. Windows desktop shows a "Searching \
> for a solution" dialog which was *the* major annoyance when something crashed, \
> rather than the actual crash.
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
>
>
> Diffs
> -----
>
> drkonqi/CMakeLists.txt eaeaad4
> drkonqi/main.cpp 7cbaae7
> drkonqi/statusnotifier.h PRE-CREATION
> drkonqi/statusnotifier.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
>
>
> Testing
> -------
>
> I crashed plasmashell, it restarted so fast that you didn't even have a black \
> screen inbetween, just the panel restarting. Afterwards I got a SNI which opened \
> DrKonqi when tapped.
> The SNI disappears after 1 minute because if you didn't bother to look after it by \
> then, you probably forgot what you did to cause the crash anyway :)
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============6474831356375450412==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126515/">https://git.reviewboard.kde.org/r/126515/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Dezember 27th, 2015, 6:24 nachm. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126515/diff/2/?file=426276#file426276line159" \
style="color: black; font-weight: bold; text-decoration: \
underline;">drkonqi/main.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
main(int argc, char* argv[])</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">159</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">// and we're not told to be unobstrusive, open DrKonqi dialog instead \
of showing an SNI</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and \
-> or surely?</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">both in code and comments.</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The and is correct:</p> <ul style="padding: 0;text-rendering: \
inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;"> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">I never want to show the dialog or a notification when we're passive.</li> \
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">I want to show the DrKonqi dialog instead of the \
KPassivePopup fallback in case no FDO notification service is available</li> \
</ul></pre> <br />
<p>- Kai Uwe</p>
<br />
<p>On Dezember 27th, 2015, 4:11 nachm. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Plasma, KDE Usability, and Martin \
Gräßlin.</div> <div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Dez. 27, 2015, 4:11 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This adds a new "--passive" option to DrKonqi where it \
will only show a StatusNotifierItem rather than bringing up the crash dialog right \
away.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This can be useful for auto-restarting shell services \
(like plasmashell, krunner, kded) to improve the perceived quality of the \
product.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On Windows RT, for example, the guidelines even \
explicitly say "rather just dump the user on the home screen than telling him \
something went wrong, so he can just quickly start the app again instead of being \
annoyed by an error message". On iOS you also just get dropped on the home screen. \
Windows desktop shows a "Searching for a solution" dialog which was <em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">the</em> major annoyance when something crashed, rather than the actual \
crash.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Video here: \
https://www.youtube.com/watch?v=t0ZLs-juYKc</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I crashed plasmashell, it restarted so fast that you \
didn't even have a black screen inbetween, just the panel restarting. Afterwards I \
got a SNI which opened DrKonqi when tapped.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The SNI disappears \
after 1 minute because if you didn't bother to look after it by then, you probably \
forgot what you did to cause the crash anyway :)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>drkonqi/CMakeLists.txt <span style="color: grey">(eaeaad4)</span></li>
<li>drkonqi/main.cpp <span style="color: grey">(7cbaae7)</span></li>
<li>drkonqi/statusnotifier.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>drkonqi/statusnotifier.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126515/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6474831356375450412==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic