[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126185: Make the KAppTemplate CMake module global
From: "Alex Merry" <alex.merry () kde ! org>
Date: 2015-12-27 11:08:39
Message-ID: 20151227110839.18086.18213 () mimi ! kde ! org
[Download RAW message or body]
--===============6428797668594953277==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126185/#review90139
-----------------------------------------------------------
Sorry for the delay; Christmas happened :-)
Just two more small (but important) things, and then we're ready to go!
kde-modules/KDEPackageAppTemplates.cmake (line 1)
<https://git.reviewboard.kde.org/r/126185/#comment61735>
This documentation won't be added to the generated docs unless you put a link \
file in the `docs/kde-module` directory. It's pretty straightforward - just copy and \
edit one of the other files in that directory.
kde-modules/KDEPackageAppTemplates.cmake (line 16)
<https://git.reviewboard.kde.org/r/126185/#comment61734>
I would phrase this as something like
INSTALL_DIR is the directory to install the template package to. In most \
cases you will want to use the variable KDE_INSTALL_KTEMPLATESDIR from \
:kde-module:`KDEInstallDirs`.
And then put a blank line before the bit about TEMPLATES, so they're separate \
paragraphs.
- Alex Merry
On Dec. 18, 2015, 10:55 a.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126185/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 10:55 a.m.)
>
>
> Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, and \
> Simon Wächter.
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> templates are very useful as teaching tool in order to make
> a minimal application that uses a certain framework.
> templates in the KAppTemplate repository will always get forgotten
> (plus kapptemplate is not really necessary as they work in kdevelop as well)
> An ideal situation would be frameworks having templates in their own repos
> with templates of barebone apps using the main framework features.
> In order to do that, the cmake stuff needed in order to correctly install
> a template needs to be ported to a place avaiable to all frameworks
>
>
> Diffs
> -----
>
> kde-modules/KDEInstallDirs.cmake b7cd34d
> kde-modules/KDEPackageAppTemplates.cmake PRE-CREATION
> tests/CMakeLists.txt 1a66f56
> tests/KDEPackageAppTemplatesTest/CMakeLists.txt PRE-CREATION
> tests/KDEPackageAppTemplatesTest/check.cmake.in PRE-CREATION
> tests/KDEPackageAppTemplatesTest/qml-plasmoid/CMakeLists.txt PRE-CREATION
> tests/KDEPackageAppTemplatesTest/qml-plasmoid/Messages.sh PRE-CREATION
> tests/KDEPackageAppTemplatesTest/qml-plasmoid/README PRE-CREATION
> tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/images/pairs.svgz \
> PRE-CREATION tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/ui/main.qml \
> PRE-CREATION tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/metadata.desktop \
> PRE-CREATION tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.kdevtemplate \
> PRE-CREATION tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.png \
> PRE-CREATION
> Diff: https://git.reviewboard.kde.org/r/126185/diff/
>
>
> Testing
> -------
>
> done some templates installed by plasma-framework
>
>
> Thanks,
>
> Marco Martin
>
>
--===============6428797668594953277==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126185/">https://git.reviewboard.kde.org/r/126185/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry \
for the delay; Christmas happened :-)</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Just two more small \
(but important) things, and then we're ready to go!</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126185/diff/8/?file=424414#file424414line1" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kde-modules/KDEPackageAppTemplates.cmake</a> <span style="font-weight: \
normal;">
(Diff revision 8)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c">#.rst:</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
documentation won't be added to the generated docs unless you put a link file in the \
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">docs/kde-module</code> directory. It's pretty \
straightforward - just copy and edit one of the other files in that \
directory.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126185/diff/8/?file=424414#file424414line16" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kde-modules/KDEPackageAppTemplates.cmake</a> <span style="font-weight: \
normal;">
(Diff revision 8)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">16</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c"># It is recommended to use ${KDE_INSTALL_KTEMPLATESDIR} as \
INSTALL_DIR</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
would phrase this as something like</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" \
style="background: #f8f8f8"><pre style="line-height: 125%">INSTALL_DIR is the \
directory to install the template package to. In most cases you will want to use the \
variable KDE_INSTALL_KTEMPLATESDIR from :kde-module:`KDEInstallDirs`. </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">And then put a blank line before the bit about \
TEMPLATES, so they're separate paragraphs.</p></pre> </div>
</div>
<br />
<p>- Alex Merry</p>
<br />
<p>On December 18th, 2015, 10:55 a.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, and \
Simon Wächter.</div> <div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Dec. 18, 2015, 10:55 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">templates are very useful as teaching tool in order to \
make a minimal application that uses a certain framework.
templates in the KAppTemplate repository will always get forgotten
(plus kapptemplate is not really necessary as they work in kdevelop as well)
An ideal situation would be frameworks having templates in their own repos
with templates of barebone apps using the main framework features.
In order to do that, the cmake stuff needed in order to correctly install
a template needs to be ported to a place avaiable to all frameworks</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">done some templates installed by \
plasma-framework</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kde-modules/KDEInstallDirs.cmake <span style="color: grey">(b7cd34d)</span></li>
<li>kde-modules/KDEPackageAppTemplates.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(1a66f56)</span></li>
<li>tests/KDEPackageAppTemplatesTest/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/check.cmake.in <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/Messages.sh <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/README <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/images/pairs.svgz \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/ui/main.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/metadata.desktop <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.kdevtemplate <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.png <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126185/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6428797668594953277==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic