[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126517: [ShellManager] Make use of StatusNotifier DrKonqi
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-12-25 17:42:02
Message-ID: 20151225174202.19541.1418 () mimi ! kde ! org
[Download RAW message or body]
--===============0332862773953558077==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dec. 25, 2015, 5:22 p.m., David Edmundson wrote:
> > On first thought this is awesome. I like the video. It looks good.
> >
> > but now I'm going to point something out that's going to ruin your Christmas
> >
> > If Plasma crashes, you're going to try and show an SNI *in plasma* ... which \
> > isn't running. That's fine for a single crash, not for ones that block startup.
> >
> > I'm sure we can workaround this somehow - there's a timer in KCrash internals \
> > where we can know if something is a crash within the first 20 seconds of loading.
>
> Kai Uwe Broulik wrote:
> That's why on third (and last) restart attempt it'll bring up DrKonqi nonetheless. \
> Good point nonetheless.
so it does.
+1
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126517/#review90102
-----------------------------------------------------------
On Dec. 25, 2015, 4:24 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126517/
> -----------------------------------------------------------
>
> (Updated Dec. 25, 2015, 4:24 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This enables the StatusNotifier option introduced in Review 126516, see Review \
> 126515 for more information.
> When Plasma reached the recursion counter it disables the passive option since \
> there will most likely be no System Tray to show this error and then something's \
> really wrong in the first place.
>
> Diffs
> -----
>
> shell/shellmanager.cpp 0a6ac5e
>
> Diff: https://git.reviewboard.kde.org/r/126517/diff/
>
>
> Testing
> -------
>
> Crashed plasma two times, it restarted and I got two SNIs, crashed it another time, \
> got black screen with DrKonqi dialog.
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============0332862773953558077==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126517/">https://git.reviewboard.kde.org/r/126517/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 25th, 2015, 5:22 p.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On first thought this is awesome. I like the video. It \
looks good.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">but now I'm going to point something out that's going \
to ruin your Christmas</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">If Plasma crashes, you're going to try \
and show an SNI <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">in plasma</em> ... which isn't running. That's fine for \
a single crash, not for ones that block startup.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
sure we can workaround this somehow - there's a timer in KCrash internals where we \
can know if something is a crash within the first 20 seconds of loading.</p></pre> \
</blockquote>
<p>On December 25th, 2015, 5:24 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">That's why on third (and last) restart attempt it'll bring up DrKonqi \
nonetheless. Good point nonetheless.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">so it \
does.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">+1</p></pre> <br />
<p>- David</p>
<br />
<p>On December 25th, 2015, 4:24 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Dec. 25, 2015, 4:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This enables the StatusNotifier option introduced in \
Review 126516, see Review 126515 for more information.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">When \
Plasma reached the recursion counter it disables the passive option since there will \
most likely be no System Tray to show this error and then something's really wrong in \
the first place.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Crashed plasma two times, it restarted and I got two \
SNIs, crashed it another time, got black screen with DrKonqi dialog.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/shellmanager.cpp <span style="color: grey">(0a6ac5e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126517/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0332862773953558077==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic