[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122859: WIP: Don't animate from previous pixmap when IconItem has been invisible
From: "Mark Gaiser" <markg85 () gmail ! com>
Date: 2015-12-24 8:12:31
Message-ID: 20151224081231.29845.20455 () mimi ! kde ! org
[Download RAW message or body]
--===============0423109962576154436==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On dec 22, 2015, 9:58 p.m., Kai Uwe Broulik wrote:
> > I suppose this is obsolete now.
>
> David Edmundson wrote:
> I don't think it is.
> The other patch was about removing a silly timer before loading a pixmap, however \
> it still always has the fade when changing source.
Is that a bad thing, fade[1] when changing sources?
If the fade (when changing sources) is very fast then it might actually look better \
to have that instead of jumping from one image to another.
Just my 5 cents :)
[1] i suppose you mean crossfade? Fading out the old image fading in the new one.
- Mark
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122859/#review89951
-----------------------------------------------------------
On mrt 14, 2015, 2:53 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122859/
> -----------------------------------------------------------
>
> (Updated mrt 14, 2015, 2:53 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> We have a lot of reusable singletons that are just hidden when unneeded (tooltip, \
> osd). IconItem, however, will always fade from the previous state, even if the \
> previous action happened minutes ago.
> This patch makes it track its visibility and skip the fade-and-wait dance when it \
> just became visible. It also removes a visible false call in the tooltip which I \
> didn't know what it was for. (With it in place, the IconItem always becomes visible \
> when moving between tooltip areas, breaking the animation altogether).
> @Eike: Could you check whether this makes it more viable for Kicker?
>
>
> Diffs
> -----
>
> src/declarativeimports/core/iconitem.h 3ef0306
> src/declarativeimports/core/iconitem.cpp d653bf3
> src/declarativeimports/core/tooltip.cpp 40e0af5
>
> Diff: https://git.reviewboard.kde.org/r/122859/diff/
>
>
> Testing
> -------
>
> Moving between tray icons - icon fades, moving reaaaally rapidly causes it not to \
> load any icon until you halt (dunno if that happened before but doesn't seem too \
> bad) Hovering tray icon, leaving, waiting, hovering another one - icon does not \
> fade, is there right away
> There is an issue with the OSD where it would not fade at all anymore when changing \
> states (eg. change volume, then screen brightness), only on the first invocation, \
> hence the "WIP" badge.
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============0423109962576154436==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122859/">https://git.reviewboard.kde.org/r/122859/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On december 22nd, 2015, 9:58 p.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I suppose this is obsolete now.</p></pre> \
</blockquote>
<p>On december 22nd, 2015, 11:19 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't think it is. The other patch was about removing a silly timer before loading a \
pixmap, however it still always has the fade when changing source.</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is \
that a bad thing, fade[1] when changing sources? If the fade (when changing sources) \
is very fast then it might actually look better to have that instead of jumping from \
one image to another.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Just my 5 cents :)</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">[1] i suppose you mean crossfade? Fading out the old image fading in the \
new one.</p></pre> <br />
<p>- Mark</p>
<br />
<p>On maart 14th, 2015, 2:53 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated mrt 14, 2015, 2:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We have a lot of reusable singletons that are just \
hidden when unneeded (tooltip, osd). IconItem, however, will always fade from the \
previous state, even if the previous action happened minutes ago.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This patch makes it track its visibility and skip the fade-and-wait dance \
when it just became visible. It also removes a visible false call in the tooltip \
which I didn't know what it was for. (With it in place, the IconItem always becomes \
visible when moving between tooltip areas, breaking the animation altogether).</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">@Eike: Could you check whether this makes it more viable for \
Kicker?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Moving between tray icons - icon fades, moving \
reaaaally rapidly causes it not to load any icon until you halt (dunno if that \
happened before but doesn't seem too bad) Hovering tray icon, leaving, waiting, \
hovering another one - icon does not fade, is there right away</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There \
is an issue with the OSD where it would not fade at all anymore when changing states \
(eg. change volume, then screen brightness), only on the first invocation, hence the \
"WIP" badge.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/core/iconitem.h <span style="color: \
grey">(3ef0306)</span></li>
<li>src/declarativeimports/core/iconitem.cpp <span style="color: \
grey">(d653bf3)</span></li>
<li>src/declarativeimports/core/tooltip.cpp <span style="color: \
grey">(40e0af5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122859/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0423109962576154436==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic