[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126460: Honor SkipGrouping hint from KNotification
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2015-12-21 20:43:41
Message-ID: 20151221204341.7793.82281 () mimi ! kde ! org
[Download RAW message or body]
--===============7596417618345674453==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dec. 21, 2015, 9:38 p.m., David Edmundson wrote:
> > This does seem like a much better way to handle the grouping, so I'll +1 this.
> >
> > But as for the actual bug that brought you here:
> > Why are we getting two notifications for everything from Plasma in the first \
> > place?
Those are I think two slightly different issues.
The lock-widgets one is I think because of multiscreen, cause
then you have two containments emitting two same notifications.
The other one, which you marked that^ as duplicate of, is likely
a combo of bug 346622 and possibly also a multiscreen thing.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126460/#review89855
-----------------------------------------------------------
On Dec. 21, 2015, 9:24 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126460/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2015, 9:24 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> https://git.reviewboard.kde.org/r/126459/ introduced new
> flag that allows to skip the grouping of notifications.
>
> This patch adapts the notifications server to that change.
>
>
> Diffs
> -----
>
> dataengines/notifications/notificationsengine.cpp 829ef4e
>
> Diff: https://git.reviewboard.kde.org/r/126460/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============7596417618345674453==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126460/">https://git.reviewboard.kde.org/r/126460/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 21st, 2015, 9:38 p.m. CET, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This does seem like a much better way to handle the \
grouping, so I'll +1 this.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">But as for the actual bug that brought \
you here: Why are we getting two notifications for everything from Plasma in the \
first place?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Those \
are I think two slightly different issues.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The lock-widgets one is \
I think because of multiscreen, cause then you have two containments emitting two \
same notifications.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The other one, which you marked that^ \
as duplicate of, is likely a combo of bug 346622 and possibly also a multiscreen \
thing.</p></pre> <br />
<p>- Martin</p>
<br />
<p>On December 21st, 2015, 9:24 p.m. CET, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Dec. 21, 2015, 9:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">https://git.reviewboard.kde.org/r/126459/ introduced \
new flag that allows to skip the grouping of notifications.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch adapts the notifications server to that \
change.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/notifications/notificationsengine.cpp <span style="color: \
grey">(829ef4e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126460/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7596417618345674453==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic