[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126373: change the taskbar color from blue to gray
From: "andreas kainz" <kainz.a () gmail ! com>
Date: 2015-12-16 0:08:50
Message-ID: 20151216000850.7434.76593 () mimi ! kde ! org
[Download RAW message or body]
--===============8933569402280649586==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dec. 16, 2015, 12:07 a.m., Kai Uwe Broulik wrote:
> > While I'm not fond of this constant change of design language, I do like that the \
> > entries now have a concise border around them; the current light blue makes them \
> > somewhat blurry. I like the gray also.
this is more something like bugfixing not add a new design cause it's fun.
- andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126373/#review89572
-----------------------------------------------------------
On Dec. 16, 2015, 12:06 a.m., andreas kainz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126373/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 12:06 a.m.)
>
>
> Review request for Plasma, Marco Martin and Uri Herrera.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Problem
> =======
> with the new taskbar we look that the look and feel is consistent between plasma \
> and the applications therefore Uri change the selected application taskbar button \
> to a blue background. The problem is that the blue background couldn't be the same \
> blue than e.g. in the dolphin sidebar cause when you select an element in the \
> sidebar the text color change from "black" to white which isn't possible in the \
> system tray and than the contrast isn't that good in the panel for selected \
> application (gray text on blue background). In addition the blue is very visible. \
> see screenshot before.
> Solution
> ========
> I like that we use the same color language but when you look at the dolphin toolbar \
> on top selected elements (e.g. preview in the screenshot) are gray so I change the \
> blue color for the selected application to gray and change minimized app to no \
> border.
> what do you think?
>
>
> Diffs
> -----
>
> src/desktoptheme/breeze/widgets/tasks.svgz 086558b
>
> Diff: https://git.reviewboard.kde.org/r/126373/diff/
>
>
> Testing
> -------
>
> I will test the new taskbar and hope someone else can test it too before we may \
> ship it.
>
> File Attachments
> ----------------
>
> taskbar style old
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/28f02c74-3489-4e35-a83f-45bd59a1e681__PlasmaThemeTaskbarBefore.png
> taskbar style new
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/1f9c7570-114d-4192-b2e5-0c713adfaad7__PlasmaThemeTaskbarAfter.png
> new tasks.svgz file move to /usr/share/plasma/desktoptheme/breeze/widgets/
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/a6faa46d-1f81-4140-824c-983f6bb5671f__tasks.svgz
>
>
> Thanks,
>
> andreas kainz
>
>
--===============8933569402280649586==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126373/">https://git.reviewboard.kde.org/r/126373/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 16th, 2015, 12:07 a.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">While I'm not fond of this constant change of design \
language, I do like that the entries now have a concise border around them; the \
current light blue makes them somewhat blurry. I like the gray also.</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
is more something like bugfixing not add a new design cause it's fun.</p></pre> <br \
/>
<p>- andreas</p>
<br />
<p>On December 16th, 2015, 12:06 a.m. UTC, andreas kainz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Marco Martin and Uri Herrera.</div>
<div>By andreas kainz.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2015, 12:06 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><h1 style="font-size: 100%;text-rendering: inherit;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">Problem</h1> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">with the new taskbar we look that the look and feel is consistent between \
plasma and the applications therefore Uri change the selected application taskbar \
button to a blue background. The problem is that the blue background couldn't be the \
same blue than e.g. in the dolphin sidebar cause when you select an element in the \
sidebar the text color change from "black" to white which isn't possible in the \
system tray and than the contrast isn't that good in the panel for selected \
application (gray text on blue background). In addition the blue is very visible. see \
screenshot before.</p> <h1 style="font-size: 100%;text-rendering: inherit;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">Solution</h1> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I like that we use the same color language but when you look at the dolphin \
toolbar on top selected elements (e.g. preview in the screenshot) are gray so I \
change the blue color for the selected application to gray and change minimized app \
to no border.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">what do you think?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I will test the new taskbar and hope someone else can \
test it too before we may ship it.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/desktoptheme/breeze/widgets/tasks.svgz <span style="color: \
grey">(086558b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126373/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/28f02c74-3489-4e35-a83f-45bd59a1e681__PlasmaThemeTaskbarBefore.png">taskbar \
style old</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/1f9c7570-114d-4192-b2e5-0c713adfaad7__PlasmaThemeTaskbarAfter.png">taskbar \
style new</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/a6faa46d-1f81-4140-824c-983f6bb5671f__tasks.svgz">new \
tasks.svgz file move to /usr/share/plasma/desktoptheme/breeze/widgets/</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8933569402280649586==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic