'Re: Review Request 126356: change minimum size of clipboard'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126356: change minimum size of clipboard
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2015-12-15 1:07:42
Message-ID: 20151215010742.7434.48490 () mimi ! kde ! org
[Download RAW message or body]

--===============3975258774174877908==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Dec. 15, 2015, 1:03 a.m., Martin Klapetek wrote:
> > I quite disagree with this change; by default my Clipboard applet
> > can barely fit 5 entries[1], making the minimum height any smaller
> > does not seem like an improvement.
> > 
> > [1] http://paste.opensuse.org/view/raw/2bea1130

yes that's a problem, but it's independent of this.

Anything in the systray effectively ignores the size hint in the applet itself and is \
sys-tray sized. 

This is only going to affect when it's standalone on the desktop.

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126356/#review89512
-----------------------------------------------------------

On Dec. 15, 2015, 12:24 a.m., andreas kainz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126356/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 12:24 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> if you use clipboard on the desktop the minimum window height is heigher than you \
> use clipboard from the panel (drop down window). As the user can define the width \
> and height for the desktop plasmoid the minimum allowed height should be at least \
> the same than the drop down window in the panel. so I change the minimumHeig to 16. \
>  
> Diffs
> -----
> 
> applets/clipboard/contents/ui/clipboard.qml 97230c1 
> 
> Diff: https://git.reviewboard.kde.org/r/126356/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> andreas kainz
> 
> 

--===============3975258774174877908==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126356/">https://git.reviewboard.kde.org/r/126356/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On December 15th, 2015, 1:03 a.m. UTC, <b>Martin \
Klapetek</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I quite disagree with this change; by default my \
Clipboard applet can barely fit 5 entries[1], making the minimum height any smaller
does not seem like an improvement.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">[1] \
http://paste.opensuse.org/view/raw/2bea1130</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yes \
that's a problem, but it's independent of this.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Anything in the systray effectively ignores the size hint in the applet \
itself and is sys-tray sized. </p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This is only going to \
affect when it's standalone on the desktop.</p></pre> <br />

<p>- David</p>

<br />
<p>On December 15th, 2015, 12:24 a.m. UTC, andreas kainz wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By andreas kainz.</div>

<p style="color: grey;"><i>Updated Dec. 15, 2015, 12:24 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">if you use clipboard on the desktop the minimum window \
height is heigher than you use clipboard from the panel (drop down window). As the \
user can define the width and height for the desktop plasmoid the minimum allowed \
height should be at least the same than the drop down window in the panel. so I \
change the minimumHeig to 16.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/clipboard/contents/ui/clipboard.qml <span style="color: \
grey">(97230c1)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126356/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3975258774174877908==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 