'Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"
From:       "Hrvoje Senjan" <hrvoje.senjan () gmail ! com>
Date:       2015-12-08 18:14:35
Message-ID: 20151208181435.30410.45199 () mimi ! kde ! org
[Download RAW message or body]

--===============8325072839100008224==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On Dec. 8, 2015, 7:51 a.m., Martin Gräßlin wrote:
> > -2 for another reason: the display system should not be a user facing part. \
> > That's a technical detail which will go away in a year or two. Do you want to \
> > rename it back to Plasma then? If at all we should change the X11 session to have \
> > the name adjusted.
> 
> David Edmundson wrote:
> If you think that, why provide the .desktop file at all when it's not ready?
> 
> Sebastian Kügler wrote:
> I think as long as Wayland is the experimental option, it should say so. The \
> specialization makes it easier to recognize the stable/X11 session. 
> David Edmundson wrote:
> What I don't get is why we're installing this file by default at all. 
> We *know* that without a kdeinit patch everything freezes. So we've just added an \
> option that we *know* will only give a black screen. That's both pointless and \
> setting a bad impression. 
> Martin Gräßlin wrote:
> > We know that without a kdeinit patch everything freezes.
> 
> To be fair I didn't know that it would freeze when the session file got added. I \
> thought it was related to another KDE session running and not just to sddm having \
> started an X server. 
> > That's both pointless and setting a bad impression.
> 
> We are not installing the file. Distros are. I don't expect any sane distro to \
> provide the wayland session installed by default. It should be possible to install \
> it, though and this includes a patched kdeinit. This is something AFAIK Arch \
> already did before we provided the session file.

It is installed by CMake w/o any patches and is said to be provided in the release \
announcement, so i guess it is safe to say that it is installed by default.

If upstream would prefer the session is not provided, best is 1) don't install it at \
all via CMake, 2) notify kde-distro-packagers that the session should rather not be \
provided.

- Hrvoje

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126275/#review89235
-----------------------------------------------------------

On Dec. 8, 2015, 3:09 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126275/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 3:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The commit/review says it's displayed as "Plasma (Wayland)"
> but the name is just "Plasma", making it confusing in login
> manager.
> 
> 
> Diffs
> -----
> 
> plasmawayland.desktop.cmake c5d5757 
> 
> Diff: https://git.reviewboard.kde.org/r/126275/diff/
> 
> 
> Testing
> -------
> 
> Sddm now clearly shows which "Plasma" is Waylandplasma.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
> 

--===============8325072839100008224==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126275/">https://git.reviewboard.kde.org/r/126275/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On December 8th, 2015, 7:51 a.m. CET, <b>Martin \
Gräßlin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">-2 for another reason: the display system should not \
be a user facing part. That's a technical detail which will go away in a year or two. \
Do you want to rename it back to Plasma then? If at all we should change the X11 \
session to have the name adjusted.</p></pre>  </blockquote>

 <p>On December 8th, 2015, 2:50 p.m. CET, <b>David Edmundson</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
you think that, why provide the .desktop file at all when it's not ready?</p></pre>  \
</blockquote>

 <p>On December 8th, 2015, 3:08 p.m. CET, <b>Sebastian Kügler</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think as long as Wayland is the experimental option, it should say so. The \
specialization makes it easier to recognize the stable/X11 session.</p></pre>  \
</blockquote>

 <p>On December 8th, 2015, 3:15 p.m. CET, <b>David Edmundson</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What \
I don't get is why we're installing this file by default at all.  We <em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">know</em> that without a kdeinit patch everything freezes. So we've just \
added an option that we <em style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">know</em> will only give a black screen. \
That's both pointless and setting a bad impression.</p></pre>  </blockquote>

 <p>On December 8th, 2015, 3:45 p.m. CET, <b>Martin Gräßlin</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">We know that without a kdeinit patch everything freezes.</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">To be fair I didn't know that it would freeze when the \
session file got added. I thought it was related to another KDE session running and \
not just to sddm having started an X server.</p> <blockquote style="text-rendering: \
inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 \
0 0 0.5em;line-height: inherit;"> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">That's both pointless \
and setting a bad impression.</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We are not installing the file. Distros are. I don't \
expect any sane distro to provide the wayland session installed by default. It should \
be possible to install it, though and this includes a patched kdeinit. This is \
something AFAIK Arch already did before we provided the session file.</p></pre>  \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It is \
installed by CMake w/o any patches and is said to be provided in the release \
announcement, so i guess it is safe to say that it is installed by default.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">If upstream would prefer the session is not provided, best is 1) don't \
install it at all via CMake, 2) notify kde-distro-packagers that the session should \
rather not be provided.</p></pre> <br />

<p>- Hrvoje</p>

<br />
<p>On December 8th, 2015, 3:09 p.m. CET, Martin Klapetek wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>

<p style="color: grey;"><i>Updated Dec. 8, 2015, 3:09 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The commit/review says it's displayed as "Plasma \
(Wayland)" but the name is just "Plasma", making it confusing in login
manager.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Sddm now clearly shows which "Plasma" is \
Waylandplasma.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasmawayland.desktop.cmake <span style="color: grey">(c5d5757)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126275/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8325072839100008224==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 