[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126248: change icons in breeze plasma theme
From: "Hrvoje Senjan" <hrvoje.senjan () gmail ! com>
Date: 2015-12-06 17:55:01
Message-ID: 20151206175501.29696.7719 () mimi ! kde ! org
[Download RAW message or body]
--===============2334020967347299510==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dec. 5, 2015, 5:56 p.m., Hrvoje Senjan wrote:
> > Andreas, battery is almost invisible with breeze dark -> \
> > http://i.imgur.com/aY1igIu.jpg
>
> andreas kainz wrote:
> you have right the problem is also the old one from master doesn't work in breeze \
> dark. maybe marco can have a look why the color change don't work.
> Andreas ka wrote:
> should work now
> http://commits.kde.org/plasma-framework/42952018ad26aa5b66cda74e7a2ea69a80187ffa
sorry, still the same. also for the amarok icon...
- Hrvoje
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126248/#review89151
-----------------------------------------------------------
On Dec. 6, 2015, 1:01 p.m., andreas kainz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126248/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2015, 1:01 p.m.)
>
>
> Review request for Plasma and Uri Herrera.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> - amarok icon now works
> - add missint nm icons (https://bugs.kde.org/show_bug.cgi?id=355412)
> - change the battery icon to be more full than now \
> https://bugs.kde.org/show_bug.cgi?id=355864
> - system icons are now available in monochrome for 22px size \
> (https://bugs.kde.org/show_bug.cgi?id=355664)
>
> Diffs
> -----
>
> src/desktoptheme/breeze/icons/amarok.svgz 1cafc36
> src/desktoptheme/breeze/icons/battery.svgz 0b90ff2
> src/desktoptheme/breeze/icons/network.svgz b7524f0
> src/desktoptheme/breeze/icons/system.svgz 8528bfe
>
> Diff: https://git.reviewboard.kde.org/r/126248/diff/
>
>
> Testing
> -------
>
> use the plasma theme monochrome system icons look good for panel applet, user \
> switch screen, ....
> Please check the battery icons cause sometime they are looking to bold. it's my \
> first plasma theme change.
>
> Thanks,
>
> andreas kainz
>
>
--===============2334020967347299510==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126248/">https://git.reviewboard.kde.org/r/126248/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 5th, 2015, 5:56 p.m. CET, <b>Hrvoje \
Senjan</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Andreas, battery is almost invisible with breeze dark \
-> http://i.imgur.com/aY1igIu.jpg</p></pre> </blockquote>
<p>On December 5th, 2015, 8:19 p.m. CET, <b>andreas kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">you \
have right the problem is also the old one from master doesn't work in breeze dark. \
maybe marco can have a look why the color change don't work.</p></pre> </blockquote>
<p>On December 5th, 2015, 9:08 p.m. CET, <b>Andreas ka</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">should work now \
http://commits.kde.org/plasma-framework/42952018ad26aa5b66cda74e7a2ea69a80187ffa</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">sorry, still the same. also for the amarok icon...</p></pre> <br />
<p>- Hrvoje</p>
<br />
<p>On December 6th, 2015, 1:01 p.m. CET, andreas kainz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Uri Herrera.</div>
<div>By andreas kainz.</div>
<p style="color: grey;"><i>Updated Dec. 6, 2015, 1:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">amarok icon now \
works</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">add missint nm icons \
(https://bugs.kde.org/show_bug.cgi?id=355412)</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">change \
the battery icon to be more full than now \
https://bugs.kde.org/show_bug.cgi?id=355864</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">system \
icons are now available in monochrome for 22px size \
(https://bugs.kde.org/show_bug.cgi?id=355664)</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">use the plasma theme monochrome system icons look good \
for panel applet, user switch screen, ....</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Please check the \
battery icons cause sometime they are looking to bold. it's my first plasma theme \
change.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/desktoptheme/breeze/icons/amarok.svgz <span style="color: \
grey">(1cafc36)</span></li>
<li>src/desktoptheme/breeze/icons/battery.svgz <span style="color: \
grey">(0b90ff2)</span></li>
<li>src/desktoptheme/breeze/icons/network.svgz <span style="color: \
grey">(b7524f0)</span></li>
<li>src/desktoptheme/breeze/icons/system.svgz <span style="color: \
grey">(8528bfe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126248/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2334020967347299510==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic