[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126234: Fix build with Qt 5.6
From: "Hrvoje Senjan" <hrvoje.senjan () gmail ! com>
Date: 2015-12-04 18:44:06
Message-ID: 20151204184406.29696.81131 () mimi ! kde ! org
[Download RAW message or body]
--===============0585490077889694141==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126234/#review89132
-----------------------------------------------------------
Jan, Martin, i guess this can also go to 5.5 branch?
- Hrvoje Senjan
On Dec. 4, 2015, 10:23 a.m., Jan Kundrát wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126234/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 10:23 a.m.)
>
>
> Review request for Plasma, Martin Gräßlin and Hrvoje Senjan.
>
>
> Repository: kwin
>
>
> Description
> -------
>
> Fix build with Qt 5.6
>
> A recent change [1] led to Qt5PlatformSupport.pc not being installed
> anymore. Pkg-config was only used for finding the paths, and the actual
> include flags and library names were hardcoded in KWin's
> FindQt5PlatformSupport.cmake anyway, so let's just focus on finding
> Qt5Gui, the module which provides this Qt5PlatformSupport library, and
> work from there.
>
> Thanks to Hrvoje Senjan (shumski) for pointing me towards the upstream
> Gerrit change.
>
> [1] https://codereview.qt-project.org/140954/
>
> REVIEW: 126234
>
>
> Diffs
> -----
>
> cmake/modules/FindQt5PlatformSupport.cmake 90a8438ac80e48b09463ba5f34a72b2d7567ea5d \
>
> Diff: https://git.reviewboard.kde.org/r/126234/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Kundrát
>
>
--===============0585490077889694141==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126234/">https://git.reviewboard.kde.org/r/126234/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Jan, \
Martin, i guess this can also go to 5.5 branch?</p></pre> <br />
<p>- Hrvoje Senjan</p>
<br />
<p>On December 4th, 2015, 10:23 a.m. CET, Jan Kundrát wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Martin Gräßlin and Hrvoje Senjan.</div>
<div>By Jan Kundrát.</div>
<p style="color: grey;"><i>Updated Dec. 4, 2015, 10:23 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fix build with Qt 5.6</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A \
recent change [1] led to Qt5PlatformSupport.pc not being installed anymore. \
Pkg-config was only used for finding the paths, and the actual include flags and \
library names were hardcoded in KWin's FindQt5PlatformSupport.cmake anyway, so let's \
just focus on finding Qt5Gui, the module which provides this Qt5PlatformSupport \
library, and work from there.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Thanks to Hrvoje Senjan (shumski) for pointing me \
towards the upstream Gerrit change.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">[1] https://codereview.qt-project.org/140954/</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">REVIEW: 126234</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindQt5PlatformSupport.cmake <span style="color: \
grey">(90a8438ac80e48b09463ba5f34a72b2d7567ea5d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126234/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0585490077889694141==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic