[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126126: kicker: always show arrows for items with children
From: "Eike Hein" <hein () kde ! org>
Date: 2015-12-02 12:13:45
Message-ID: 20151202121345.29696.91370 () mimi ! kde ! org
[Download RAW message or body]
--===============2985982503132136976==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Nov. 30, 2015, 1:50 p.m., Marco Martin wrote:
> > ping? what's the status of this?
>
> Eike Hein wrote:
> I was waiting for Pino, but here's a shot of the proposed variant:
>
> ![All arrows everywhere](http://i.imgur.com/FwAmgGZ.png)
>
> Marco Martin wrote:
> it looks aa bit more busy indeed, but may really help for submenus that have both \
> categories and apps
> Kai Uwe Broulik wrote:
> I like it. It might help to add "usability" to such review requests.
>
> Martin Klapetek wrote:
> Should kickoff maybe get those arrows too? I think that similar case applies there \
> to its submenus.
> Kai Uwe Broulik wrote:
> Plasma 4 kickoff had them.
I'll enable them in both today.
- Eike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126126/#review88963
-----------------------------------------------------------
On Nov. 21, 2015, 12:25 p.m., Pino Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126126/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2015, 12:25 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Always show the arrow in menu items which represent a submenu, instead
> of only when hovering on them. This eases the discovery of which items
> are actually submenus as opposed to actual entries.
>
>
> Diffs
> -----
>
> applets/kicker/package/contents/ui/ItemListDelegate.qml \
> becf13d278862b20f46eacae628364708abadfdc
> Diff: https://git.reviewboard.kde.org/r/126126/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pino Toscano
>
>
--===============2985982503132136976==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126126/">https://git.reviewboard.kde.org/r/126126/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 30th, 2015, 1:50 p.m. UTC, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">ping? what's the status of this?</p></pre> \
</blockquote>
<p>On November 30th, 2015, 9:32 p.m. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I was \
waiting for Pino, but here's a shot of the proposed variant:</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><img \
alt="All arrows everywhere" src="http://i.imgur.com/FwAmgGZ.png" style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" \
/></p></pre> </blockquote>
<p>On December 1st, 2015, 11:51 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it \
looks aa bit more busy indeed, but may really help for submenus that have both \
categories and apps</p></pre> </blockquote>
<p>On December 1st, 2015, 12:01 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
like it. It might help to add "usability" to such review requests.</p></pre> \
</blockquote>
<p>On December 1st, 2015, 1:41 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Should kickoff maybe get those arrows too? I think that similar case \
applies there to its submenus.</p></pre> </blockquote>
<p>On December 1st, 2015, 2:31 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Plasma 4 kickoff had them.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll \
enable them in both today.</p></pre> <br />
<p>- Eike</p>
<br />
<p>On November 21st, 2015, 12:25 p.m. UTC, Pino Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Pino Toscano.</div>
<p style="color: grey;"><i>Updated Nov. 21, 2015, 12:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Always show the arrow in menu items which represent a \
submenu, instead of only when hovering on them. This eases the discovery of which \
items are actually submenus as opposed to actual entries.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kicker/package/contents/ui/ItemListDelegate.qml <span style="color: \
grey">(becf13d278862b20f46eacae628364708abadfdc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126126/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2985982503132136976==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic