[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126203: Disable ptrace for kcheckpass and the greeter
From: "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date: 2015-12-01 15:19:51
Message-ID: 20151201151951.29696.41138 () mimi ! kde ! org
[Download RAW message or body]
--===============8594296080655455734==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126203/#review89002
-----------------------------------------------------------
Ship it!
Thanks for spending time making this portable.
I'm unable to test this at the moment; if Tobias is around and able to submit a \
FreeBSD version it'd be good to integrate it into the same patch, otherwise we can \
just do that later.
- Raphael Kubo da Costa
On Dec. 1, 2015, 3:13 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126203/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2015, 3:13 p.m.)
>
>
> Review request for Plasma and Tobias Berner.
>
>
> Repository: kscreenlocker
>
>
> Description
> -------
>
> Setting the PR_SET_DUMPABLE flag to 0 for the security relevant
> command kcheckpass and kscreenlocker_greet. If one wants to gdb into
> the running command it will result in:
>
> ptrace: Operation not permitted.
>
> For kscreenlocker_greet ptrace is permitted in testing mode.
>
> As root it's still possible to attach to the process.
>
> ---
>
> @Tobias: I assume this is a strong linux-ism. Is there a FreeBSD compareable \
> functionality?
> I'm considering to push this explicitly without an ifdef. It's a new security \
> feature and I want to make non-Linux systems aware of the fact that it adds a new \
> feature and that a replacement should be added.
>
> Diffs
> -----
>
> CMakeLists.txt f48bd53cafc188f79e041518dae0769d57597c69
> config-kscreenlocker.h.cmake 2a034dee8ec21e426bc1db1d56b0ed152d3de2ca
> greeter/main.cpp e4e679e7ef40b319665428281fdba5f4e0b4eb25
> kcheckpass/kcheckpass.c fd2d2215bf2199f159a121bb0ce08e7b2b254aaa
>
> Diff: https://git.reviewboard.kde.org/r/126203/diff/
>
>
> Testing
> -------
>
> Tried to gdb into the processes: failed
> Tried to gdb into kscreenlocker_greet --testing: succeeded
> Tried to gdb into kscreenlocker_greet as root: succeeded
>
>
> Thanks,
>
> Martin Gräßlin
>
>
--===============8594296080655455734==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126203/">https://git.reviewboard.kde.org/r/126203/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks for spending time making this portable.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
unable to test this at the moment; if Tobias is around and able to submit a FreeBSD \
version it'd be good to integrate it into the same patch, otherwise we can just do \
that later.</p></pre> <br />
<p>- Raphael Kubo da Costa</p>
<br />
<p>On December 1st, 2015, 3:13 p.m. EET, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Tobias Berner.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Dec. 1, 2015, 3:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kscreenlocker
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Setting the PR_SET_DUMPABLE flag to 0 for the security \
relevant command kcheckpass and kscreenlocker_greet. If one wants to gdb into
the running command it will result in:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">ptrace: Operation not permitted.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">For kscreenlocker_greet ptrace is permitted in testing mode.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">As root it's still possible to attach to the process.</p> <hr \
style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px \
solid #ddd;line-height: inherit;" /> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">@Tobias: I assume this \
is a strong linux-ism. Is there a FreeBSD compareable functionality?</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I'm considering to push this explicitly without an ifdef. It's a new \
security feature and I want to make non-Linux systems aware of the fact that it adds \
a new feature and that a replacement should be added.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tried to gdb into the processes: failed Tried to gdb \
into kscreenlocker_greet --testing: succeeded Tried to gdb into kscreenlocker_greet \
as root: succeeded</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(f48bd53cafc188f79e041518dae0769d57597c69)</span></li>
<li>config-kscreenlocker.h.cmake <span style="color: \
grey">(2a034dee8ec21e426bc1db1d56b0ed152d3de2ca)</span></li>
<li>greeter/main.cpp <span style="color: \
grey">(e4e679e7ef40b319665428281fdba5f4e0b4eb25)</span></li>
<li>kcheckpass/kcheckpass.c <span style="color: \
grey">(fd2d2215bf2199f159a121bb0ce08e7b2b254aaa)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126203/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8594296080655455734==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic