From kde-panel-devel Mon Nov 30 18:11:13 2015 From: "Kai Uwe Broulik" Date: Mon, 30 Nov 2015 18:11:13 +0000 To: kde-panel-devel Subject: Re: Review Request 126207: [Compact Applet] Don't break the dialog size binding Message-Id: <20151130181113.29696.57100 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=144890708713382 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0741525756462179824==" --===============0741525756462179824== Content-Type: multipart/alternative; boundary="===============2530871232652343100==" --===============2530871232652343100== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126207/#review88973 ----------------------------------------------------------- On the other hand, if PlasmaCore.Dialog respected Layout.preferredWidth/Layout.preferredHeight we could remove all of this (except the initial setting for restoring a width)? - Kai Uwe Broulik On Nov. 30, 2015, 5:56 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126207/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2015, 5:56 nachm.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > We must not break the binding on the dialog's size, otherwise changing the preferredWidth/height of a dialog won't affect it. > > > Diffs > ----- > > desktoppackage/contents/applet/CompactApplet.qml b5bbc70 > > Diff: https://git.reviewboard.kde.org/r/126207/diff/ > > > Testing > ------- > > I wasted hours on finding out why User Manager dialog sizing was broken, re-writing it several times /o\ > > Changing Layout.preferredHeight changes the dialog size, Layout.minimumHeight/Layout.maximumHeight constraints still work. Didn't notice breakage with other applets. > > > Thanks, > > Kai Uwe Broulik > > --===============2530871232652343100== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126207/

On the other hand, if PlasmaCore.Dialog respected Layout.preferredWidth/Layout.preferredHeight we could remove all of this (except the initial setting for restoring a width)?

- Kai Uwe Broulik

On November 30th, 2015, 5:56 nachm. UTC, Kai Uwe Broulik wrote:

Review request for Plasma.

By Kai Uwe Broulik.

Updated Nov. 30, 2015, 5:56 nachm.

Repository: plasma-desktop

Description

We must not break the binding on the dialog's size, otherwise changing the preferredWidth/height of a dialog won't affect it.

Testing

I wasted hours on finding out why User Manager dialog sizing was broken, re-writing it several times /o\

Changing Layout.preferredHeight changes the dialog size, Layout.minimumHeight/Layout.maximumHeight constraints still work. Didn't notice breakage with other applets.

Diffs

desktoppackage/contents/applet/CompactApplet.qml (b5bbc70)

View Diff

--===============2530871232652343100==-- --===============0741525756462179824== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============0741525756462179824==--