'Review Request 126207: [Compact Applet] Don't break the dialog size binding'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 126207: [Compact Applet] Don't break the dialog size binding
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2015-11-30 17:56:09
Message-ID: 20151130175609.29696.34824 () mimi ! kde ! org
[Download RAW message or body]

--===============4304018476599318985==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126207/
-----------------------------------------------------------

Review request for Plasma.

Repository: plasma-desktop

Description
-------

We must not break the binding on the dialog's size, otherwise changing the \
preferredWidth/height of a dialog won't affect it.

Diffs
-----

  desktoppackage/contents/applet/CompactApplet.qml b5bbc70 

Diff: https://git.reviewboard.kde.org/r/126207/diff/

Testing
-------

I wasted hours on finding out why User Manager dialog sizing was broken, re-writing \
it several times /o\

Changing Layout.preferredHeight changes the dialog size, \
Layout.minimumHeight/Layout.maximumHeight constraints still work. Didn't notice \
breakage with other applets.

Thanks,

Kai Uwe Broulik

--===============4304018476599318985==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126207/">https://git.reviewboard.kde.org/r/126207/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We must not break the binding on the dialog's size, \
otherwise changing the preferredWidth/height of a dialog won't affect it.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I wasted hours on finding out why User Manager dialog \
sizing was broken, re-writing it several times /o\</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Changing Layout.preferredHeight changes the dialog size, \
Layout.minimumHeight/Layout.maximumHeight constraints still work. Didn't notice \
breakage with other applets.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>desktoppackage/contents/applet/CompactApplet.qml <span style="color: \
grey">(b5bbc70)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126207/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4304018476599318985==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 