[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126185: Make the KAppTemplate CMake module global
From: Simon_Wächter <waechter.simon () gmail ! com>
Date: 2015-11-30 14:23:07
Message-ID: 20151130142307.29696.5050 () mimi ! kde ! org
[Download RAW message or body]
--===============1494612136370144058==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Nov. 27, 2015, 6:21 p.m., Simon Wächter wrote:
> > Thanks for moving the template macro to the ECM module. A few things I am not \
> > quite sure:
> > - Is the .kdev_ignore file still in use? I never saw it in a KDevelop project
> > - If you commit the patch, I'll delete the macro from KAppTemplate and move all \
> > templates to the specific projects
> > - I also should write a second macro, that tests the generated application - but \
> > since I started my Bachelor I completely run out off time :/
>
> Marco Martin wrote:
> the file is pushed.
> about the .kdev_ignore file i'm not sure.. Aleix, do you know about that?
>
> Marco Martin wrote:
> I removed the plasmoid template from kapptemplate, as it would conflict with the \
> one installed by plasma-framework during packaging the cmake macro is still there \
> (and they don't conflict as the macro name is different)
Ok thank you, I'll clean up KAppTemplate
- Simon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126185/#review88898
-----------------------------------------------------------
On Nov. 30, 2015, 2:47 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126185/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2015, 2:47 p.m.)
>
>
> Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Simon Wächter.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> templates are very useful as teaching tool in order to make
> a minimal application that uses a certain framework.
> templates in the KAppTemplate repository will always get forgotten
> (plus kapptemplate is not really necessary as they work in kdevelop as well)
> An ideal situation would be frameworks having templates in their own repos
> with templates of barebone apps using the main framework features.
> In order to do that, the cmake stuff needed in order to correctly install
> a template needs to be ported to a place avaiable to all frameworks
>
>
> Diffs
> -----
>
> kde-modules/KDETemplateMacro.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/126185/diff/
>
>
> Testing
> -------
>
> done some templates installed by plasma-framework
>
>
> Thanks,
>
> Marco Martin
>
>
--===============1494612136370144058==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126185/">https://git.reviewboard.kde.org/r/126185/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 27th, 2015, 6:21 p.m. CET, <b>Simon \
Wächter</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Thanks for moving the template macro to the ECM \
module. A few things I am not quite sure:</p> <ul style="padding: 0;text-rendering: \
inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;"> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Is the .kdev_ignore file still in use? I never saw it in a KDevelop \
project</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">If you commit the patch, I'll delete the macro from \
KAppTemplate and move all templates to the specific projects</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">I also \
should write a second macro, that tests the generated application - but since I \
started my Bachelor I completely run out off time :/</li> </ul></pre>
</blockquote>
<p>On November 30th, 2015, 2:48 p.m. CET, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the \
file is pushed. about the .kdev_ignore file i'm not sure.. Aleix, do you know about \
that?</p></pre> </blockquote>
<p>On November 30th, 2015, 3:06 p.m. CET, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
removed the plasmoid template from kapptemplate, as it would conflict with the one \
installed by plasma-framework during packaging the cmake macro is still there (and \
they don't conflict as the macro name is different)</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok \
thank you, I'll clean up KAppTemplate</p></pre> <br />
<p>- Simon</p>
<br />
<p>On November 30th, 2015, 2:47 p.m. CET, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Simon \
Wächter.</div> <div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Nov. 30, 2015, 2:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">templates are very useful as teaching tool in order to \
make a minimal application that uses a certain framework.
templates in the KAppTemplate repository will always get forgotten
(plus kapptemplate is not really necessary as they work in kdevelop as well)
An ideal situation would be frameworks having templates in their own repos
with templates of barebone apps using the main framework features.
In order to do that, the cmake stuff needed in order to correctly install
a template needs to be ported to a place avaiable to all frameworks</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">done some templates installed by \
plasma-framework</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kde-modules/KDETemplateMacro.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126185/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1494612136370144058==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic