[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126175: Click on item in plasmashell case focus stays on last pointed item
From: "Anthony Fieroni" <bvbfan () abv ! bg>
Date: 2015-11-30 4:39:37
Message-ID: 20151130043937.29696.55145 () mimi ! kde ! org
[Download RAW message or body]
--===============8306632042821730243==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Ноев. 30, 2015, 1:25 преди обяд, David Edmundson wrote:
> > > MoseMove is too expensive event to be redirect, it can cause problems on slow \
> > > CPU's.
> >
> > I don't see how.
> > It's no different to when the mouse is actually over the containment.
> >
> > The case for when you're in the 4px margin at the edge of the panel seems like it \
> > must be tiny.
First of all, you don't understaind the problem at all. Every postEvent is expensive, \
not for allocating memory, case event is append to queque. Here problem is simple - \
QEvent::Leave is append to queque *before* MouseMove, this behavior can be easy \
preproduce at slower CPU's like mine. To make redirect on evey mousemove is not only \
stupid, it's more expencive than any other event.
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126175/#review88931
-----------------------------------------------------------
On Ноев. 28, 2015, 5:30 преди обяд, Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126175/
> -----------------------------------------------------------
>
> (Updated Ноев. 28, 2015, 5:30 преди обяд)
>
>
> Review request for Plasma, David Edmundson and Marco Martin.
>
>
> Bugs: 354651
> https://bugs.kde.org/show_bug.cgi?id=354651
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> You can see videos in bug repot
>
>
> Diffs
> -----
>
> shell/panelview.cpp 3407501
>
> Diff: https://git.reviewboard.kde.org/r/126175/diff/
>
>
> Testing
> -------
>
> I test patch and all works as expected.
> http://doc.qt.io/qt-5/qevent.html
> QEvent::Leave 11 Mouse leaves widget's boundaries.
>
>
> Thanks,
>
> Anthony Fieroni
>
>
--===============8306632042821730243==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126175/">https://git.reviewboard.kde.org/r/126175/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Ноември 30th, 2015, 1:25 преди \
обяд EET, <b>David Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: \
inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 \
0 0 0.5em;line-height: inherit;"> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">MoseMove is too \
expensive event to be redirect, it can cause problems on slow CPU's.</p> \
</blockquote> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I don't see how. It's no different to when the mouse \
is actually over the containment.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The case for when \
you're in the 4px margin at the edge of the panel seems like it must be \
tiny.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">First \
of all, you don't understaind the problem at all. Every postEvent is expensive, not \
for allocating memory, case event is append to queque. Here problem is simple - \
QEvent::Leave is append to queque <em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">before</em> MouseMove, \
this behavior can be easy preproduce at slower CPU's like mine. To make redirect on \
evey mousemove is not only stupid, it's more expencive than any other \
event.</p></pre> <br />
<p>- Anthony</p>
<br />
<p>On Ноември 28th, 2015, 5:30 преди обяд EET, Anthony Fieroni \
wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, David Edmundson and Marco Martin.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Ноев. 28, 2015, 5:30 преди \
обяд</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=354651">354651</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">You can see videos in bug repot</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I test patch and all works as expected. \
http://doc.qt.io/qt-5/qevent.html QEvent::Leave 11 Mouse leaves widget's \
boundaries.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/panelview.cpp <span style="color: grey">(3407501)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126175/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8306632042821730243==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic