'Re: Review Request 126187: [Kickoff] Extract i18n also from .js files'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126187: [Kickoff] Extract i18n also from .js files
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2015-11-28 9:51:21
Message-ID: 20151128095121.23104.75055 () mimi ! kde ! org
[Download RAW message or body]

--===============6778770608635052805==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126187/
-----------------------------------------------------------

(Updated Nov. 28, 2015, 9:51 a.m.)

Status
------

This change has been marked as submitted.

Review request for Localization and Translation (l10n) and Plasma.

Changes
-------

Submitted with commit a1f32c55fa454eb7d7553bb43e16c57a1c19e8a1 by Kai Uwe Broulik to branch \
Plasma/5.5.

Repository: plasma-desktop

Description
-------

The "Add to Favorites" and "Remove from Favorites" action come from the tools.js file.

Should that go into 5.5? It would add new translations, sure, but they might be fixed for a \
minor release, otherwise they'd stay untranslated for all of 5.5

Diffs
-----

  applets/kickoff/Messages.sh 034133a 

Diff: https://git.reviewboard.kde.org/r/126187/diff/

Testing
-------

No.

Thanks,

Kai Uwe Broulik

--===============6778770608635052805==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126187/">https://git.reviewboard.kde.org/r/126187/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Localization and Translation (l10n) and Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Nov. 28, 2015, 9:51 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit \
a1f32c55fa454eb7d7553bb43e16c57a1c19e8a1 by Kai Uwe Broulik to branch Plasma/5.5.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The "Add to \
Favorites" and "Remove from Favorites" action come from the tools.js file.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Should that go into 5.5? It would add new translations, sure, but they might be fixed \
for a minor release, otherwise they'd stay untranslated for all of 5.5</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/kickoff/Messages.sh <span style="color: grey">(034133a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126187/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6778770608635052805==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 