[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126178: [Kicker] Add support for Jump Lists
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2015-11-27 18:29:19
Message-ID: 20151127182919.20118.3352 () mimi ! kde ! org
[Download RAW message or body]
--===============7258236674543141735==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126178/
-----------------------------------------------------------
(Updated Nov. 27, 2015, 6:29 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma, KDE Usability and Eike Hein.
Changes
-------
Submitted with commit 49ca2ee6bbd9278bd80bbf4b192271efcbe81c8c by Kai Uwe Broulik to \
branch master.
Repository: plasma-desktop
Description
-------
This adds support for "Additional applications actions" (aka Jumplists).
Not sure about the "Tasks" heading. I probably added it to provide more separation to \
the (kinda out of place "remove from favorites").
Note to Usability: The exact same functionality will also be available to Kickoff and \
the Application Dashboard. Also, the two actions shown for Kate I added myself for \
testing; they are kinda useless and won't be shipped. Chromium doesn't have recent \
documents, so I added to showcase when both list types are available.
Diffs
-----
applets/kicker/plugin/actionlist.h 7a543da
applets/kicker/plugin/actionlist.cpp 87c9b51
applets/kicker/plugin/appentry.cpp ecb18ac
applets/kicker/plugin/recentusagemodel.cpp bd9efa1
Diff: https://git.reviewboard.kde.org/r/126178/diff/
Testing
-------
Works for applications. Could not test history as I could get neither chromium nor \
kate to show up there. Also a pity that none of these features are available to \
search results.
File Attachments
----------------
Kicker Jump List
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/26/e614da13-8e9a-4d42-b54e-8c6ab4af5f12__kickeractions.png
Thanks,
Kai Uwe Broulik
--===============7258236674543141735==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126178/">https://git.reviewboard.kde.org/r/126178/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, KDE Usability and Eike Hein.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Nov. 27, 2015, 6:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 49ca2ee6bbd9278bd80bbf4b192271efcbe81c8c by Kai \
Uwe Broulik to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This adds support for "Additional applications \
actions" (aka Jumplists).</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Not sure about the "Tasks" heading. I \
probably added it to provide more separation to the (kinda out of place "remove from \
favorites").</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Note to Usability: The exact same functionality will \
also be available to Kickoff and the Application Dashboard. Also, the two actions \
shown for Kate I added myself for testing; they are kinda useless and won't be \
shipped. Chromium doesn't have recent documents, so I added to showcase when both \
list types are available.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works for applications. Could not test history as I \
could get neither chromium nor kate to show up there. Also a pity that none of these \
features are available to search results.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kicker/plugin/actionlist.h <span style="color: \
grey">(7a543da)</span></li>
<li>applets/kicker/plugin/actionlist.cpp <span style="color: \
grey">(87c9b51)</span></li>
<li>applets/kicker/plugin/appentry.cpp <span style="color: \
grey">(ecb18ac)</span></li>
<li>applets/kicker/plugin/recentusagemodel.cpp <span style="color: \
grey">(bd9efa1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126178/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/11/26/e614da13-8e9a-4d42-b54e-8c6ab4af5f12__kickeractions.png">Kicker \
Jump List</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7258236674543141735==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic