[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager
From: "Jonathan Riddell" <jr () jriddell ! org>
Date: 2015-11-27 14:47:00
Message-ID: 20151127144700.23104.66814 () mimi ! kde ! org
[Download RAW message or body]
--===============1622182948774148164==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Nov. 23, 2015, 11:21 p.m., Thomas Pfeiffer wrote:
> > The interaction seems fine, but since it's a user setting, there should not be \
> > any polkit request. This would confuse users because they don't expect to need \
> > admin rights to change their own profile picture.
>
> Jonathan Riddell wrote:
> it uses accountsservice so it'll need polkit. whether or not it asks for a \
> password is up to accountsservice
> Kai Uwe Broulik wrote:
> But asking for a password (multiple times) when changing the *own* user picture is \
> really a no-go.
It only asks me once. On Kubuntu 15.10.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126151/#review88745
-----------------------------------------------------------
On Nov. 23, 2015, 9:50 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126151/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 9:50 p.m.)
>
>
> Review request for Plasma, KDE Usability and Jonathan Riddell.
>
>
> Bugs: 354001
> http://bugs.kde.org/show_bug.cgi?id=354001
>
>
> Repository: user-manager
>
>
> Description
> -------
>
> Including the avatars, that are no longer installed into /usr/share/kdm/icons but \
> /usr/share/user-manager/avatars. I don't know if there's a FDO location for these.
>
> Diffs
> -----
>
> src/CMakeLists.txt 7267d24
> src/accountinfo.h c6e70b3
> src/accountinfo.cpp 878f683
> src/avatargallery.h PRE-CREATION
> src/avatargallery.cpp PRE-CREATION
> src/avatargallery.ui PRE-CREATION
> src/pics/Ada Lovelace.png PRE-CREATION
> src/pics/Alice in Wonderland.png PRE-CREATION
> src/pics/Blackbox.png PRE-CREATION
> src/pics/CMakeLists.txt PRE-CREATION
> src/pics/Dragon.png PRE-CREATION
> src/pics/Grace Hopper.png PRE-CREATION
> src/pics/Green.png PRE-CREATION
> src/pics/Happy.png PRE-CREATION
> src/pics/Kati.png PRE-CREATION
> src/pics/Konqui.png PRE-CREATION
> src/pics/Leonardo da Vinci.png PRE-CREATION
> src/pics/Listening.png PRE-CREATION
> src/pics/Logger.png PRE-CREATION
> src/pics/Mahatma Gandhi.png PRE-CREATION
> src/pics/Mowgli jungle book.png PRE-CREATION
> src/pics/Notme.png PRE-CREATION
> src/pics/Parley.png PRE-CREATION
> src/pics/Rekonqui.png PRE-CREATION
> src/pics/TV.png PRE-CREATION
> src/pics/User.png PRE-CREATION
> src/pics/bomb.png PRE-CREATION
> src/pics/sources/Ada Lovelace.svg PRE-CREATION
> src/pics/sources/Alice in Wonderland.svg PRE-CREATION
> src/pics/sources/Dragon.svg PRE-CREATION
> src/pics/sources/Grace Hopper.svg PRE-CREATION
> src/pics/sources/Kati.svg PRE-CREATION
> src/pics/sources/Konqui.svg PRE-CREATION
> src/pics/sources/Leonardo da Vinci.svg PRE-CREATION
> src/pics/sources/Logger.svg PRE-CREATION
> src/pics/sources/Mahatma Gandhi.svg PRE-CREATION
> src/pics/sources/Mowgli jungle book.svg PRE-CREATION
> src/pics/sources/Parley.svg PRE-CREATION
> src/pics/sources/Rekonqui.svg PRE-CREATION
> src/pics/sources/User.svg PRE-CREATION
> src/pics/sources/blackbox.svgz PRE-CREATION
> src/pics/sources/bomb.svgz PRE-CREATION
> src/pics/sources/green.svgz PRE-CREATION
> src/pics/sources/happy.svgz PRE-CREATION
> src/pics/sources/listening.svgz PRE-CREATION
> src/pics/sources/notme.svgz PRE-CREATION
> src/pics/sources/tv.svgz PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/126151/diff/
>
>
> Testing
> -------
>
> Opened user manager, clicked my icon, clicked "Choose from Gallery", chose an icon, \
> OK. It prompted me three times for Polkit authentication for some reason but in the \
> end it worked, Kickoff also immediately updated its icon.
>
> File Attachments
> ----------------
>
> New menu option
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/23/d91c818f-5051-4857-beb2-b2727614f187__usermanageravatar.png
> Avatar gallery
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/23/2f16fa25-5eac-4e6a-b24d-7d47ff560ce4__usermanageravatar2.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============1622182948774148164==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126151/">https://git.reviewboard.kde.org/r/126151/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 23rd, 2015, 11:21 p.m. UTC, <b>Thomas \
Pfeiffer</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The interaction seems fine, but since it's a user \
setting, there should not be any polkit request. This would confuse users because \
they don't expect to need admin rights to change their own profile picture.</p></pre> \
</blockquote>
<p>On November 27th, 2015, 2:34 p.m. UTC, <b>Jonathan Riddell</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it \
uses accountsservice so it'll need polkit. whether or not it asks for a password is \
up to accountsservice</p></pre> </blockquote>
<p>On November 27th, 2015, 2:43 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But \
asking for a password (multiple times) when changing the <em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">own</em> user picture is really a no-go.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It \
only asks me once. On Kubuntu 15.10.</p></pre> <br />
<p>- Jonathan</p>
<br />
<p>On November 23rd, 2015, 9:50 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, KDE Usability and Jonathan Riddell.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Nov. 23, 2015, 9:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=354001">354001</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
user-manager
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Including the avatars, that are no longer installed \
into /usr/share/kdm/icons but /usr/share/user-manager/avatars. I don't know if \
there's a FDO location for these.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Opened user manager, clicked my icon, clicked "Choose \
from Gallery", chose an icon, OK. It prompted me three times for Polkit \
authentication for some reason but in the end it worked, Kickoff also immediately \
updated its icon.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(7267d24)</span></li>
<li>src/accountinfo.h <span style="color: grey">(c6e70b3)</span></li>
<li>src/accountinfo.cpp <span style="color: grey">(878f683)</span></li>
<li>src/avatargallery.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/avatargallery.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/avatargallery.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/Ada Lovelace.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/Alice in Wonderland.png <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/pics/Blackbox.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/Dragon.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/Grace Hopper.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/Green.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/Happy.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/Kati.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/Konqui.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/Leonardo da Vinci.png <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/pics/Listening.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/Logger.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/Mahatma Gandhi.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/Mowgli jungle book.png <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/pics/Notme.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/Parley.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/Rekonqui.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/TV.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/User.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/bomb.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/sources/Ada Lovelace.svg <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/pics/sources/Alice in Wonderland.svg <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/pics/sources/Dragon.svg <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/sources/Grace Hopper.svg <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/pics/sources/Kati.svg <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/sources/Konqui.svg <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/sources/Leonardo da Vinci.svg <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/pics/sources/Logger.svg <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/sources/Mahatma Gandhi.svg <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/pics/sources/Mowgli jungle book.svg <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/pics/sources/Parley.svg <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/sources/Rekonqui.svg <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/pics/sources/User.svg <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/sources/blackbox.svgz <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/pics/sources/bomb.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/sources/green.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/sources/happy.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/sources/listening.svgz <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/pics/sources/notme.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/pics/sources/tv.svgz <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126151/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/11/23/d91c818f-5051-4857-beb2-b2727614f187__usermanageravatar.png">New \
menu option</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/11/23/2f16fa25-5eac-4e6a-b24d-7d47ff560ce4__usermanageravatar2.png">Avatar \
gallery</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1622182948774148164==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic