[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126149: [Icon widget] Bring back properties dialog
From: "Marco Martin" <notmart () gmail ! com>
Date: 2015-11-25 15:17:30
Message-ID: 20151125151730.23104.62885 () mimi ! kde ! org
[Download RAW message or body]
--===============4402385214890522681==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Nov. 23, 2015, 10:04 p.m., Eike Hein wrote:
> > The problem with this is that the old applet had the properties widget embedded \
> > as a page into the applet config dialog. This probably replaces the latter, \
> > killing the keyboard shortcut page and making it not possible to configure a \
> > hotkey anymore ...?
>
> Kai Uwe Broulik wrote:
> The old applet also just opened the KPropertiesDialog.
>
> Eike Hein wrote:
> This will still make it hard for users to access config UI they might have come to \
> rely on (shortcuts) so it's a regression vs. the last stable release. This needs to \
> be addressed somehow, reverting to Plasma 4 behavior is a bit of a stretch IMHO.
> Kai Uwe Broulik wrote:
> Alternatively we could keep the (empty) settings dialog as is and add another \
> context menu option for the icon settings, like we do with a couple of applets that \
> can spawn a KCM.
> Marco Martin wrote:
> yeah, a second context menu item would be good in this case i think
>
> Kai Uwe Broulik wrote:
> Okay.
>
> One thing I noticed is that when I edit eg. Kate and apply in the dialog, it adds \
> this Kate to the "open with" actions but never removes them again and now I have 20 \
> Kate entries there :( Any idea how to prevent this?
perhaps when editing an icon that is installed globally, it then creates a copy in \
the home, and then disaster ensues?
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review88741
-----------------------------------------------------------
On Nov. 23, 2015, 8:54 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 8:54 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: ?
> https://bugs.kde.org/show_bug.cgi?id=?
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This brings back the KPropertiesDialog to modify an icon's appearance. This has \
> been requested at multiple occasions. This has been adapted from the Plasma 4 icon \
> code.
>
> Diffs
> -----
>
> applets/icon/package/contents/ui/main.qml 9286b94
> applets/icon/plugin/icon_p.h dd7963c
> applets/icon/plugin/icon_p.cpp e086870
>
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
>
>
> Testing
> -------
>
> Dropped a file from my home onto the desktop -> dialog from the actual file, \
> allowing to rename it. The applet reflected the changes.
> Dropped an application from kickoff to the desktop -> dialog from a copy of the \
> desktop file, allowing to change its icon and description. The applet reflected the \
> changes.
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============4402385214890522681==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126149/">https://git.reviewboard.kde.org/r/126149/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 23rd, 2015, 10:04 p.m. UTC, <b>Eike \
Hein</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The problem with this is that the old applet had the \
properties widget embedded as a page into the applet config dialog. This probably \
replaces the latter, killing the keyboard shortcut page and making it not possible to \
configure a hotkey anymore ...?</p></pre> </blockquote>
<p>On November 23rd, 2015, 10:07 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
old applet also just opened the KPropertiesDialog.</p></pre> </blockquote>
<p>On November 23rd, 2015, 10:10 p.m. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
will still make it hard for users to access config UI they might have come to rely on \
(shortcuts) so it's a regression vs. the last stable release. This needs to be \
addressed somehow, reverting to Plasma 4 behavior is a bit of a stretch \
IMHO.</p></pre> </blockquote>
<p>On November 23rd, 2015, 10:15 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Alternatively we could keep the (empty) settings dialog as is and add \
another context menu option for the icon settings, like we do with a couple of \
applets that can spawn a KCM.</p></pre> </blockquote>
<p>On November 25th, 2015, 3:09 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yeah, \
a second context menu item would be good in this case i think</p></pre> \
</blockquote>
<p>On November 25th, 2015, 3:13 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Okay.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">One thing I noticed is that when I edit \
eg. Kate and apply in the dialog, it adds this Kate to the "open with" actions but \
never removes them again and now I have 20 Kate entries there :( Any idea how to \
prevent this?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">perhaps when editing an icon that is installed globally, it then creates a \
copy in the home, and then disaster ensues?</p></pre> <br />
<p>- Marco</p>
<br />
<p>On November 23rd, 2015, 8:54 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Nov. 23, 2015, 8:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=?">?</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This brings back the KPropertiesDialog to modify an \
icon's appearance. This has been requested at multiple occasions. This has been \
adapted from the Plasma 4 icon code.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Dropped a file from my home onto the desktop -> \
dialog from the actual file, allowing to rename it. The applet reflected the \
changes.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Dropped an application from kickoff to the desktop \
-> dialog from a copy of the desktop file, allowing to change its icon and \
description. The applet reflected the changes.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/icon/package/contents/ui/main.qml <span style="color: \
grey">(9286b94)</span></li>
<li>applets/icon/plugin/icon_p.h <span style="color: grey">(dd7963c)</span></li>
<li>applets/icon/plugin/icon_p.cpp <span style="color: grey">(e086870)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126149/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4402385214890522681==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic