'Re: Review Request 126014: fix: kcms/input and kcms/touchpad should not be built if XInput is not pr'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126014: fix: kcms/input and kcms/touchpad should not be built if XInput is not pr
From:       "Johan Ouwerkerk" <jm.ouwerkerk () gmail ! com>
Date:       2015-11-25 14:17:35
Message-ID: 20151125141735.23104.66724 () mimi ! kde ! org
[Download RAW message or body]

--===============8040753564056997718==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126014/
-----------------------------------------------------------

(Updated Nov. 25, 2015, 2:17 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit 0bd4f5d4777d1aa5978a67ee90bd8a963a245687 by Sebastian Kügler \
to branch Plasma/5.5.

Repository: plasma-desktop

Description
-------

Previously the presence of evdev headers would enable the kcms/input KCM module, and \
the presence of synaptics driver headers would enable the touchpad module. However, \
both KCMs unconditionally depend on XInput in some way in a (sub) CMakelists.txt file \
and deliberately break the build if it is not present or not properly detected.

As per the convention in the KCM modules shipped by plasma-desktop, inclusion of the \
kcms/input and kcms/touchpad subdirectory is made conditional on XInput being present \
and properly detected during the cmake configure stage.

This patch can be pulled from the fix-cmake-xinput-dep branch at: \
git@github.com:cmacq2/plasma-desktop.git

Diffs
-----

  kcms/CMakeLists.txt 321fbebba49dad32d237f3941dea9fedaf1a8e5a 

Diff: https://git.reviewboard.kde.org/r/126014/diff/

Testing
-------

Built without XInput development files, using kdesrc-build.

Thanks,

Johan Ouwerkerk

--===============8040753564056997718==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126014/">https://git.reviewboard.kde.org/r/126014/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Johan Ouwerkerk.</div>

<p style="color: grey;"><i>Updated Nov. 25, 2015, 2:17 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 0bd4f5d4777d1aa5978a67ee90bd8a963a245687 by \
Sebastian Kügler to branch Plasma/5.5.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Previously the presence of evdev headers would enable \
the kcms/input KCM module, and the presence of synaptics driver headers would enable \
the touchpad module. However, both KCMs unconditionally depend on XInput in some way \
in a (sub) CMakelists.txt file and deliberately break the build if it is not present \
or not properly detected.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">As per the convention in the KCM \
modules shipped by plasma-desktop, inclusion of the kcms/input and kcms/touchpad \
subdirectory is made conditional on XInput being present and properly detected during \
the cmake configure stage.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This patch can be pulled from the \
fix-cmake-xinput-dep branch at: git@github.com:cmacq2/plasma-desktop.git</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Built without XInput development files, using \
kdesrc-build.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcms/CMakeLists.txt <span style="color: \
grey">(321fbebba49dad32d237f3941dea9fedaf1a8e5a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126014/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8040753564056997718==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 