'Re: Review Request 126127: [powerdevil] add missing initializations, minor string optimizations'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126127: [powerdevil] add missing initializations,  minor string optimizations
From:       "Nick Shaforostoff" <shafff () ukr ! net>
Date:       2015-11-21 21:03:34
Message-ID: 20151121210334.14400.97202 () mimi ! kde ! org
[Download RAW message or body]

--===============1077627161463482326==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126127/
-----------------------------------------------------------

(Updated Nov. 21, 2015, 9:03 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma, Kai Uwe Broulik and Xuetian Weng.

Changes
-------

Submitted with commit 5b0faeb67e02edb22bf79699c4ef2217f248a945 by Nick Shaforostoff \
to branch master.

Repository: powerdevil

Description
-------

This patch fixes member variable initialization related issues found by Coverity \
static analyzer.

Also there are few minor qstring-related optimizations, plus switching from qlist to \
qvector for storing ints (consumes less memory, doesn't affect speed)

Diffs
-----

  daemon/backends/upower/powerdevilupowerbackend.cpp ff21f4e 
  daemon/backends/upower/xrandrxcbhelper.cpp 9a8f49e 
  daemon/kdedpowerdevil.cpp 6e92578 
  daemon/kwinkscreenhelpereffect.h 4d0a163 
  daemon/powerdevilaction.cpp 187f3fb 
  daemon/powerdevilbackendinterface.cpp 86d7f7e 
  daemon/powerdevilpolicyagent.cpp 6b46c9c 

Diff: https://git.reviewboard.kde.org/r/126127/diff/

Testing
-------

compiles fine

Thanks,

Nick Shaforostoff

--===============1077627161463482326==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126127/">https://git.reviewboard.kde.org/r/126127/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Kai Uwe Broulik and Xuetian Weng.</div>
<div>By Nick Shaforostoff.</div>

<p style="color: grey;"><i>Updated Nov. 21, 2015, 9:03 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 5b0faeb67e02edb22bf79699c4ef2217f248a945 by Nick \
Shaforostoff to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
powerdevil
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch fixes member variable initialization \
related issues found by Coverity static analyzer.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also \
there are few minor qstring-related optimizations, plus switching from qlist to \
qvector for storing ints (consumes less memory, doesn't affect speed)</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">compiles fine</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>daemon/backends/upower/powerdevilupowerbackend.cpp <span style="color: \
grey">(ff21f4e)</span></li>

 <li>daemon/backends/upower/xrandrxcbhelper.cpp <span style="color: \
grey">(9a8f49e)</span></li>

 <li>daemon/kdedpowerdevil.cpp <span style="color: grey">(6e92578)</span></li>

 <li>daemon/kwinkscreenhelpereffect.h <span style="color: grey">(4d0a163)</span></li>

 <li>daemon/powerdevilaction.cpp <span style="color: grey">(187f3fb)</span></li>

 <li>daemon/powerdevilbackendinterface.cpp <span style="color: \
grey">(86d7f7e)</span></li>

 <li>daemon/powerdevilpolicyagent.cpp <span style="color: grey">(6b46c9c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126127/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1077627161463482326==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 