[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126126: kicker: always show arrows for items with children
From: "Pino Toscano" <pino () kde ! org>
Date: 2015-11-21 15:24:55
Message-ID: 20151121152455.14400.70282 () mimi ! kde ! org
[Download RAW message or body]
--===============7403949418747952915==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Nov. 21, 2015, 3:05 p.m., Eike Hein wrote:
> > This is intentional because in particular the root menu looks quite ugly and busy \
> > with all arrows ...
To me a menu with submenu entries not marked as such (if not when hovering them) is \
ugly, inconsistent with every other menu around, and lead me thinking "oh, there must \
be something wrong, no submenus?" when I looked at it at first.
Can you please point me at discussions and/or design documents where this incoherency \
has been decided? Thanks.
- Pino
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126126/#review88672
-----------------------------------------------------------
On Nov. 21, 2015, 12:25 p.m., Pino Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126126/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2015, 12:25 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Always show the arrow in menu items which represent a submenu, instead
> of only when hovering on them. This eases the discovery of which items
> are actually submenus as opposed to actual entries.
>
>
> Diffs
> -----
>
> applets/kicker/package/contents/ui/ItemListDelegate.qml \
> becf13d278862b20f46eacae628364708abadfdc
> Diff: https://git.reviewboard.kde.org/r/126126/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pino Toscano
>
>
--===============7403949418747952915==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126126/">https://git.reviewboard.kde.org/r/126126/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On novembre 21st, 2015, 3:05 p.m. UTC, <b>Eike \
Hein</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is intentional because in particular the root \
menu looks quite ugly and busy with all arrows ...</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To me \
a menu with submenu entries not marked as such (if not when hovering them) is ugly, \
inconsistent with every other menu around, and lead me thinking "oh, there must be \
something wrong, no submenus?" when I looked at it at first.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can \
you please point me at discussions and/or design documents where this incoherency has \
been decided? Thanks.</p></pre> <br />
<p>- Pino</p>
<br />
<p>On novembre 21st, 2015, 12:25 p.m. UTC, Pino Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Pino Toscano.</div>
<p style="color: grey;"><i>Updated Nov. 21, 2015, 12:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Always show the arrow in menu items which represent a \
submenu, instead of only when hovering on them. This eases the discovery of which \
items are actually submenus as opposed to actual entries.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kicker/package/contents/ui/ItemListDelegate.qml <span style="color: \
grey">(becf13d278862b20f46eacae628364708abadfdc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126126/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7403949418747952915==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic