[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126101: allow loading backends in-process
From: Àlex_Fiestas <afiestas () kde ! org>
Date: 2015-11-20 19:03:07
Message-ID: 20151120190307.14400.72265 () mimi ! kde ! org
[Download RAW message or body]
--===============2813013477773277363==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126101/#review88657
-----------------------------------------------------------
src/backendmanager.cpp (lines 114 - 120)
<https://git.reviewboard.kde.org/r/126101/#comment60776>
Is this code duplicated? It seems like the code I wrote years ago and I guess now \
we need it in two places, the out and in process loaders, no?
- Àlex Fiestas
On nov. 20, 2015, 12:16 a.m., Sebastian Kügler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126101/
> -----------------------------------------------------------
>
> (Updated nov. 20, 2015, 12:16 a.m.)
>
>
> Review request for Plasma, Solid, Àlex Fiestas, Aleix Pol Gonzalez, Daniel \
> Vrátil, and Martin Gräßlin.
>
> Repository: libkscreen
>
>
> Description
> -------
>
> This patchset adds in-process operation to libkscreen
>
> purpose:
> - allow easier debugging
> - for some backends (qscreen, upcoming kwayland) the out of process operation is \
> not necessary since these backends are well-shielded
> This implementation is backwards compatible and opt-in for running setups.
>
> If the user exports KSCREEN_BACKEND_INPROCESS=1 before running, all operations will \
> be done in process. Otherwise, the out-of-process mode is used.
> Changes revolve around the ConfigOperations, the BackendManager (which "factories" \
> the backends, either in- or out-of-process), and the plugin loading logic
> Autotests should cover all the cases (and actually a few currently unsupported \
> ones, such as using different backends in the same process).
> Details on performance, etc.: \
> http://vizzzion.org/blog/2015/11/wayland-and-libkscreen-benchmarks/
>
> Diffs
> -----
>
> CMakeLists.txt 86a0965
> autotests/CMakeLists.txt 69af7f0
> autotests/testconfigmonitor.cpp a051226
> autotests/testinprocess.cpp PRE-CREATION
> autotests/testqscreenbackend.cpp da4dbae
> autotests/testscreenconfig.cpp ecbcedf
> autotests/testxrandr.cpp b9b838a
> backends/fake/fake.cpp 60264dd
> src/backendlauncher/backendloader.cpp 52051df
> src/backendmanager.cpp ca9c746
> src/backendmanager_p.h c6418e2
> src/config.cpp 75d947d
> src/configmonitor.h b6f1189
> src/configmonitor.cpp a14bc70
> src/configoperation.h 2405d79
> src/configoperation.cpp 87fe141
> src/configoperation_p.h afdc462
> src/getconfigoperation.h c85bfaa
> src/getconfigoperation.cpp 22f92b4
> src/output.cpp bd381fa
> src/setconfigoperation.h 020a990
> src/setconfigoperation.cpp 6ea944f
>
> Diff: https://git.reviewboard.kde.org/r/126101/diff/
>
>
> Testing
> -------
>
> Added a ton of autotests, made sure all existing ones pass.
>
> tried "KSCREEN_BACKEND_INPROCESS=1 kcmshell5 kscreen", all working as expected.
>
>
> Thanks,
>
> Sebastian Kügler
>
>
--===============2813013477773277363==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126101/">https://git.reviewboard.kde.org/r/126101/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126101/diff/3/?file=417472#file417472line114" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/backendmanager.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">BackendManager *BackendManager::instance()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">114</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">KScreen</span><span class="o">::</span><span \
class="n">AbstractBackend</span> <span class="o">*</span><span \
class="n">BackendManager</span><span class="o">::</span><span \
class="n">loadBackendPlugin</span><span class="p">(</span><span \
class="n">QPluginLoader</span> <span class="o">*</span><span \
class="n">loader</span><span class="p">,</span> <span class="k">const</span> <span \
class="n">QString</span> <span class="o">&</span><span class="n">name</span><span \
class="p">,</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">115</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">const</span> <span class="n">QVariantMap</span> <span \
class="o">&</span><span class="n">arguments</span><span \
class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">116</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">117</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">//qCDebug(KSCREEN) << "Requested backend:" << \
name;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">118</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">const</span> <span class="n">QString</span> <span \
class="n">backendFilter</span> <span class="o">=</span> <span \
class="n">QString</span><span class="o">::</span><span \
class="n">fromLatin1</span><span class="p">(</span><span \
class="s">"KSC_%1*"</span><span class="p">).</span><span \
class="n">arg</span><span class="p">(</span><span class="n">name</span><span \
class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">119</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">const</span> <span class="n">QStringList</span> <span \
class="n">paths</span> <span class="o">=</span> <span \
class="n">QCoreApplication</span><span class="o">::</span><span \
class="n">libraryPaths</span><span class="p">();</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">120</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">//qCDebug(KSCREEN) << "Lookup paths: " << \
paths;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this code duplicated? \
It seems like the code I wrote years ago and I guess now we need it in two places, \
the out and in process loaders, no?</pre> </div>
</div>
<br />
<p>- Àlex Fiestas</p>
<br />
<p>On novembre 20th, 2015, 12:16 a.m. UTC, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Solid, Àlex Fiestas, Aleix Pol Gonzalez, Daniel \
Vrátil, and Martin Gräßlin.</div> <div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated nov. 20, 2015, 12:16 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkscreen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patchset adds in-process operation to \
libkscreen</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">purpose:
- allow easier debugging
- for some backends (qscreen, upcoming kwayland) the out of process operation is not \
necessary since these backends are well-shielded</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
implementation is backwards compatible and opt-in for running setups.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">If the user exports KSCREEN_BACKEND_INPROCESS=1 before running, all \
operations will be done in process. Otherwise, the out-of-process mode is used.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Changes revolve around the ConfigOperations, the \
BackendManager (which "factories" the backends, either in- or out-of-process), and \
the plugin loading logic</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Autotests should cover all the cases \
(and actually a few currently unsupported ones, such as using different backends in \
the same process).</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Details on performance, etc.: \
http://vizzzion.org/blog/2015/11/wayland-and-libkscreen-benchmarks/</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Added a ton of autotests, made sure all existing ones \
pass.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">tried "KSCREEN_BACKEND_INPROCESS=1 kcmshell5 kscreen", \
all working as expected.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(86a0965)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(69af7f0)</span></li>
<li>autotests/testconfigmonitor.cpp <span style="color: grey">(a051226)</span></li>
<li>autotests/testinprocess.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/testqscreenbackend.cpp <span style="color: grey">(da4dbae)</span></li>
<li>autotests/testscreenconfig.cpp <span style="color: grey">(ecbcedf)</span></li>
<li>autotests/testxrandr.cpp <span style="color: grey">(b9b838a)</span></li>
<li>backends/fake/fake.cpp <span style="color: grey">(60264dd)</span></li>
<li>src/backendlauncher/backendloader.cpp <span style="color: \
grey">(52051df)</span></li>
<li>src/backendmanager.cpp <span style="color: grey">(ca9c746)</span></li>
<li>src/backendmanager_p.h <span style="color: grey">(c6418e2)</span></li>
<li>src/config.cpp <span style="color: grey">(75d947d)</span></li>
<li>src/configmonitor.h <span style="color: grey">(b6f1189)</span></li>
<li>src/configmonitor.cpp <span style="color: grey">(a14bc70)</span></li>
<li>src/configoperation.h <span style="color: grey">(2405d79)</span></li>
<li>src/configoperation.cpp <span style="color: grey">(87fe141)</span></li>
<li>src/configoperation_p.h <span style="color: grey">(afdc462)</span></li>
<li>src/getconfigoperation.h <span style="color: grey">(c85bfaa)</span></li>
<li>src/getconfigoperation.cpp <span style="color: grey">(22f92b4)</span></li>
<li>src/output.cpp <span style="color: grey">(bd381fa)</span></li>
<li>src/setconfigoperation.h <span style="color: grey">(020a990)</span></li>
<li>src/setconfigoperation.cpp <span style="color: grey">(6ea944f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126101/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2813013477773277363==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic