[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125862: Add simple calendar events plugin based on KHolidays
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-11-18 17:53:43
Message-ID: 20151118175343.10937.30231 () mimi ! kde ! org
[Download RAW message or body]
--===============4714834308082255824==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Nov. 18, 2015, 9:14 a.m., Kai Uwe Broulik wrote:
> > plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp, line 37
> > <https://git.reviewboard.kde.org/r/125862/diff/2/?file=417230#file417230line37>
> >
> > Add context this
>
> Martin Klapetek wrote:
> Isn't "this" caputred implicitly?
no, but it is captured by "="
If it wasn't you'd have had a compile error.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125862/#review88512
-----------------------------------------------------------
On Nov. 18, 2015, 12:33 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125862/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2015, 12:33 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This is very simple for now as there is no configuration
> yet, so it just takes the default region (your locale)
> and shows holidays from that.
>
> Obviously this needs a config to set up which regions
> you want to show in there, but this is a start.
>
>
> Diffs
> -----
>
> CMakeLists.txt 4783a78
> plasmacalendarintegration/CMakeLists.txt PRE-CREATION
> plasmacalendarintegration/HolidaysConfig.qml PRE-CREATION
> plasmacalendarintegration/holidayeventsplugin.json PRE-CREATION
> plasmacalendarintegration/holidaysevents.h PRE-CREATION
> plasmacalendarintegration/holidaysevents.cpp PRE-CREATION
> plasmacalendarintegration/qmlhelper/CMakeLists.txt PRE-CREATION
> plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.h PRE-CREATION
> plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp PRE-CREATION
> plasmacalendarintegration/qmlhelper/qmldir PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/125862/diff/
>
>
> Testing
> -------
>
> Holidays are properly listed in calendar applet.
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============4714834308082255824==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125862/">https://git.reviewboard.kde.org/r/125862/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 18th, 2015, 9:14 a.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125862/diff/2/?file=417230#file417230line37" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">37</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">connect</span><span class="p">(</span><span class="k">this</span><span \
class="p">,</span> <span class="o">&</span><span \
class="n">QmlConfigHelper</span><span class="o">::</span><span \
class="n">selectedRegionsChanged</span><span class="p">,</span> <span \
class="p">[</span><span class="o">=</span><span class="p">]</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add \
context this</p></pre> </blockquote>
<p>On November 18th, 2015, 5:18 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Isn't \
"this" caputred implicitly?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">no, but it is captured by "=" If it wasn't you'd have had a compile \
error.</p></pre> <br />
<p>- David</p>
<br />
<p>On November 18th, 2015, 12:33 a.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Nov. 18, 2015, 12:33 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is very simple for now as there is no \
configuration yet, so it just takes the default region (your locale)
and shows holidays from that.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Obviously this needs a config to set up which regions \
you want to show in there, but this is a start.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Holidays are properly listed in calendar \
applet.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(4783a78)</span></li>
<li>plasmacalendarintegration/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmacalendarintegration/HolidaysConfig.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmacalendarintegration/holidayeventsplugin.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmacalendarintegration/holidaysevents.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmacalendarintegration/holidaysevents.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmacalendarintegration/qmlhelper/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasmacalendarintegration/qmlhelper/qmldir <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125862/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4714834308082255824==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic