[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request 126101: allow loading backends in-process
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2015-11-17 20:35:06
Message-ID: 20151117203506.14400.52475 () mimi ! kde ! org
[Download RAW message or body]
--===============1706900375553370997==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126101/
-----------------------------------------------------------
Review request for Plasma, Solid, Aleix Pol Gonzalez, Daniel Vrátil, and Martin \
Gräßlin.
Repository: libkscreen
Description
-------
This patchset adds in-process operation to libkscreen
purpose:
- allow easier debugging
- for some backends (qscreen, upcoming kwayland) the out of process operation is not \
necessary since these backends are well-shielded
This implementation is backwards compatible and should mean only minimal changes to \
running setups.
If the user exports KSCREEN_BACKEND_INPROCESS=1 before running, all operations will \
be done in process. Otherwise, the out-of-process mode is used.
The idea is that we use
The changes in the clients to use the in-process mode are to use \
ConfigOperation::create() and ConfigOperation::setOperation() to retrieve the get or \
set config jobs. The rest will be handled inside libkscreen.
Autotests should cover all the cases (and actually a few currently unsupported ones, \
such as using different backends in the same process).
Details on performance, etc.: \
http://vizzzion.org/blog/2015/11/wayland-and-libkscreen-benchmarks/
Diffs
-----
CMakeLists.txt 86a0965
autotests/CMakeLists.txt 69af7f0
autotests/testconfigmonitor.cpp a051226
autotests/testinprocess.cpp PRE-CREATION
autotests/testqscreenbackend.cpp da4dbae
autotests/testscreenconfig.cpp ecbcedf
backends/fake/fake.cpp 60264dd
src/CMakeLists.txt 4b56b61
src/backendlauncher/backendloader.cpp 52051df
src/backendmanager.cpp ca9c746
src/backendmanager_p.h c6418e2
src/config.cpp 75d947d
src/configmonitor.h b6f1189
src/configmonitor.cpp a14bc70
src/configoperation.h 2405d79
src/configoperation.cpp 87fe141
src/getconfigoperation.h c85bfaa
src/inprocessconfigoperation.h PRE-CREATION
src/inprocessconfigoperation.cpp PRE-CREATION
src/output.cpp bd381fa
src/setconfigoperation.cpp 6ea944f
src/setinprocessoperation.h PRE-CREATION
src/setinprocessoperation.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/126101/diff/
Testing
-------
Added a ton of autotests, made sure all existing ones pass.
tried "KSCREEN_BACKEND_INPROCESS=1 kcmshell5 kscreen", all working as expected.
Thanks,
Sebastian Kügler
--===============1706900375553370997==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126101/">https://git.reviewboard.kde.org/r/126101/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Solid, Aleix Pol Gonzalez, Daniel Vrátil, and Martin \
Gräßlin.</div> <div>By Sebastian Kügler.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkscreen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patchset adds in-process operation to \
libkscreen</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">purpose:
- allow easier debugging
- for some backends (qscreen, upcoming kwayland) the out of process operation is not \
necessary since these backends are well-shielded</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
implementation is backwards compatible and should mean only minimal changes to \
running setups.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">If the user exports \
KSCREEN_BACKEND_INPROCESS=1 before running, all operations will be done in process. \
Otherwise, the out-of-process mode is used.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The idea is that we use \
The changes in the clients to use the in-process mode are to use \
ConfigOperation::create() and ConfigOperation::setOperation() to retrieve the get or \
set config jobs. The rest will be handled inside libkscreen.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Autotests should cover all the cases (and actually a few currently \
unsupported ones, such as using different backends in the same process).</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Details on performance, etc.: \
http://vizzzion.org/blog/2015/11/wayland-and-libkscreen-benchmarks/</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Added a ton of autotests, made sure all existing ones \
pass.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">tried "KSCREEN_BACKEND_INPROCESS=1 kcmshell5 kscreen", \
all working as expected.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(86a0965)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(69af7f0)</span></li>
<li>autotests/testconfigmonitor.cpp <span style="color: grey">(a051226)</span></li>
<li>autotests/testinprocess.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/testqscreenbackend.cpp <span style="color: grey">(da4dbae)</span></li>
<li>autotests/testscreenconfig.cpp <span style="color: grey">(ecbcedf)</span></li>
<li>backends/fake/fake.cpp <span style="color: grey">(60264dd)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(4b56b61)</span></li>
<li>src/backendlauncher/backendloader.cpp <span style="color: \
grey">(52051df)</span></li>
<li>src/backendmanager.cpp <span style="color: grey">(ca9c746)</span></li>
<li>src/backendmanager_p.h <span style="color: grey">(c6418e2)</span></li>
<li>src/config.cpp <span style="color: grey">(75d947d)</span></li>
<li>src/configmonitor.h <span style="color: grey">(b6f1189)</span></li>
<li>src/configmonitor.cpp <span style="color: grey">(a14bc70)</span></li>
<li>src/configoperation.h <span style="color: grey">(2405d79)</span></li>
<li>src/configoperation.cpp <span style="color: grey">(87fe141)</span></li>
<li>src/getconfigoperation.h <span style="color: grey">(c85bfaa)</span></li>
<li>src/inprocessconfigoperation.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/inprocessconfigoperation.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/output.cpp <span style="color: grey">(bd381fa)</span></li>
<li>src/setconfigoperation.cpp <span style="color: grey">(6ea944f)</span></li>
<li>src/setinprocessoperation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/setinprocessoperation.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126101/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1706900375553370997==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic