'Re: Review Request 126037: Drop setuid of `kcheckpass`/Use LIBEXEC_INSTALL_DIR wherever appropriate'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126037: Drop setuid of `kcheckpass`/Use LIBEXEC_INSTALL_DIR wherever appropriate
From:       "Elias Probst" <mail () eliasprobst ! eu>
Date:       2015-11-12 8:23:51
Message-ID: 20151112082351.23976.6273 () mimi ! kde ! org
[Download RAW message or body]

--===============3787784311662757041==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126037/
-----------------------------------------------------------

(Updated Nov. 12, 2015, 8:23 a.m.)

Status
------

This change has been discarded.

Review request for Plasma, Bhushan Shah and Martin Gräßlin.

Repository: kscreenlocker

Description
-------

Drop obsolete 'setuid' of kcheckpass and fragile code using $ENV{DESTDIR}.

kcheckpass works just fine without setuid nowadays and quite a few
distributions already dropped setuid of if since quite some time.

Also use `LIBEXEC_INSTALL_DIR` instead of one of the dozens of other variants for \
consistency.

Diffs
-----

  config-kscreenlocker.h.cmake 2a034dee8ec21e426bc1db1d56b0ed152d3de2ca 
  greeter/CMakeLists.txt 317bfa3cdadf05a9a8597ed40a3dc3c0af4d144d 
  kcheckpass/CMakeLists.txt a63fa1403e897e70989dc2e1ba7eed4bc69cbb51 

Diff: https://git.reviewboard.kde.org/r/126037/diff/

Testing
-------

`kcheckpass` and `kscreenlocker_greet` end up in the expected target directory \
(`/usr/lib64/libexec` on Gentoo). `kcheckpass` works as expected. I'm not sure yet \
about `kscreenlocker_greet` as I ended up with an un-unlockable session but also saw \
this issue before.

Thanks,

Elias Probst

--===============3787784311662757041==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126037/">https://git.reviewboard.kde.org/r/126037/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Bhushan Shah and Martin Gräßlin.</div>
<div>By Elias Probst.</div>

<p style="color: grey;"><i>Updated Nov. 12, 2015, 8:23 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kscreenlocker
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Drop obsolete 'setuid' of kcheckpass and fragile code \
using $ENV{DESTDIR}.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">kcheckpass works just fine without \
setuid nowadays and quite a few distributions already dropped setuid of if since \
quite some time.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Also use <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">LIBEXEC_INSTALL_DIR</code> instead of one of the dozens of other variants \
for consistency.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">kcheckpass</code> and <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">kscreenlocker_greet</code> end up in the expected target directory (<code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">/usr/lib64/libexec</code> on Gentoo). <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">kcheckpass</code> works as expected. I'm not sure yet about \
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">kscreenlocker_greet</code> as I ended up with \
an un-unlockable session but also saw this issue before.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>config-kscreenlocker.h.cmake <span style="color: \
grey">(2a034dee8ec21e426bc1db1d56b0ed152d3de2ca)</span></li>

 <li>greeter/CMakeLists.txt <span style="color: \
grey">(317bfa3cdadf05a9a8597ed40a3dc3c0af4d144d)</span></li>

 <li>kcheckpass/CMakeLists.txt <span style="color: \
grey">(a63fa1403e897e70989dc2e1ba7eed4bc69cbb51)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126037/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3787784311662757041==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 