'Re: Review Request 126031: [appletinterface] Allow specifying separate toolTipIcon'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126031: [appletinterface] Allow specifying separate toolTipIcon
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2015-11-11 20:06:34
Message-ID: 20151111200634.23976.26867 () mimi ! kde ! org
[Download RAW message or body]

--===============7672614856137069074==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126031/#review88264
-----------------------------------------------------------

I like the applet previews in widget explorer but making them the actual applet icon \
was a not completely thought through. The tooltip icons are a mess now, Kickoff \
doesn't have the KDE logo anymore, not to mention the clocks. System Tray "More \
Entries" config icons are useless now (you can't tell anything at 16x16) etc. But I \
guess it's too late to fix that now..

- Kai Uwe Broulik

On Nov. 11, 2015, 7:39 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126031/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2015, 7:39 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> With the new applet icons it can be desireable to remove the tooltip icon. This is \
> especially prominent with the clocks where the small icon shows a random date \
> causing confusion. 
> Problem with Plasmoid.icon is that it also affects eg. the undo notification, \
> unsetting it would show a KDE logo there. 
> 
> Diffs
> -----
> 
> src/scriptengines/qml/plasmoid/appletinterface.h 40016b1 
> src/scriptengines/qml/plasmoid/appletinterface.cpp 60b7fa5 
> 
> Diff: https://git.reviewboard.kde.org/r/126031/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

--===============7672614856137069074==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126031/">https://git.reviewboard.kde.org/r/126031/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
like the applet previews in widget explorer but making them the actual applet icon \
was a not completely thought through. The tooltip icons are a mess now, Kickoff \
doesn't have the KDE logo anymore, not to mention the clocks. System Tray "More \
Entries" config icons are useless now (you can't tell anything at 16x16) etc. But I \
guess it's too late to fix that now..</p></pre>  <br />

<p>- Kai Uwe Broulik</p>

<br />
<p>On November 11th, 2015, 7:39 nachm. UTC, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Nov. 11, 2015, 7:39 nachm.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">With the new applet icons it can be desireable to \
remove the tooltip icon. This is especially prominent with the clocks where the small \
icon shows a random date causing confusion.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Problem with \
Plasmoid.icon is that it also affects eg. the undo notification, unsetting it would \
show a KDE logo there.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/scriptengines/qml/plasmoid/appletinterface.h <span style="color: \
grey">(40016b1)</span></li>

 <li>src/scriptengines/qml/plasmoid/appletinterface.cpp <span style="color: \
grey">(60b7fa5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126031/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7672614856137069074==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 