[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 125951: [calendar] Move the plugins handling to a separate class
From: "Nick Shaforostoff" <shafff () ukr ! net>
Date: 2015-11-09 22:18:46
Message-ID: 20151109221846.23976.2112 () mimi ! kde ! org
[Download RAW message or body]
--===============1849064928901526125==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125951/#review88206
-----------------------------------------------------------
src/declarativeimports/calendar/eventpluginsmanager.cpp (line 42)
<https://git.reviewboard.kde.org/r/125951/#comment60491>
please use QByteArrayLiteral("configUi")
src/declarativeimports/calendar/eventpluginsmanager.cpp (line 68)
<https://git.reviewboard.kde.org/r/125951/#comment60490>
QStringLiteral("MetaData"). this is important because data() method is called a \
lot.
src/declarativeimports/calendar/eventpluginsmanager.cpp (line 79)
<https://git.reviewboard.kde.org/r/125951/#comment60489>
in order to reduce malloc/free call count (and the data() method is called a lot) \
please use leftRef() instead of left() and % instead of + three lines below (or make \
sure + is the same as % by adding define -DQT_USE_QSTRINGBUILDER)
- Nick Shaforostoff
On Nov. 9, 2015, 7:56 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125951/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2015, 7:56 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> This is also made a QML singleton that will be used for the applet
> config view where it will add the plugin configs once we add that
> possibility.
>
> The same instance is then set to the DaysModel from QML.
>
> (this depends on https://git.reviewboard.kde.org/r/125817/ which awaits ship it)
>
>
> Diffs
> -----
>
> src/declarativeimports/calendar/CMakeLists.txt \
> 40ead911ad5208cae5dbe5333d227f9f8a0d9154 \
> src/declarativeimports/calendar/calendarplugin.cpp \
> bafe80cf7520a08312abfd1dbd6d4648a6710175 \
> src/declarativeimports/calendar/daysmodel.h \
> a5bdac98627f7efa76bd4afd239469b53e06690b \
> src/declarativeimports/calendar/daysmodel.cpp \
> 2d059a8e8636565adbe52811e602fff37a5eb157 \
> src/declarativeimports/calendar/eventpluginsmanager.h PRE-CREATION \
> src/declarativeimports/calendar/eventpluginsmanager.cpp PRE-CREATION \
> src/declarativeimports/calendar/qml/MonthView.qml \
> f698934f850ef3a917b9611c9f9a40c369b23f6c
> Diff: https://git.reviewboard.kde.org/r/125951/diff/
>
>
> Testing
> -------
>
> Calendar events are still correctly displayed
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============1849064928901526125==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125951/">https://git.reviewboard.kde.org/r/125951/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125951/diff/3/?file=416064#file416064line42" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/declarativeimports/calendar/eventpluginsmanager.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">42</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_roles</span><span class="p">.</span><span class="n">insert</span><span \
class="p">(</span><span class="n">Qt</span><span class="o">::</span><span \
class="n">UserRole</span><span class="p">,</span> <span \
class="s">"configUi"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">please use \
QByteArrayLiteral("configUi")</pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125951/diff/3/?file=416064#file416064line68" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/declarativeimports/calendar/eventpluginsmanager.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">68</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">const</span> <span class="n">QJsonObject</span> <span \
class="n">metadata</span> <span class="o">=</span> <span \
class="n">m_manager</span><span class="o">-></span><span \
class="n">m_availablePlugins</span><span class="p">.</span><span \
class="n">value</span><span class="p">(</span><span \
class="n">currentPlugin</span><span class="p">).</span><span \
class="n">value</span><span class="p">(</span><span \
class="s">"MetaData"</span><span class="p">).</span><span \
class="n">toObject</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">QStringLiteral("MetaData"). this is important because data() \
method is called a lot.</pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125951/diff/3/?file=416064#file416064line79" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/declarativeimports/calendar/eventpluginsmanager.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">79</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">const</span> <span class="n">QString</span> <span \
class="n">path</span> <span class="o">=</span> <span \
class="n">currentPlugin</span><span class="p">.</span><span \
class="n">left</span><span class="p">(</span><span \
class="n">currentPlugin</span><span class="p">.</span><span \
class="n">lastIndexOf</span><span class="p">(</span><span \
class="sc">'/'</span><span class="p">));</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">in order to reduce \
malloc/free call count (and the data() method is called a lot) please use leftRef() \
instead of left() and % instead of + three lines below (or make sure + is the same as \
% by adding define -DQT_USE_QSTRINGBUILDER)</pre> </div>
</div>
<br />
<p>- Nick Shaforostoff</p>
<br />
<p>On November 9th, 2015, 7:56 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Nov. 9, 2015, 7:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is also made a QML singleton that will be used \
for the applet config view where it will add the plugin configs once we add that
possibility.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The same instance is then set to the DaysModel from \
QML.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">(this depends on \
https://git.reviewboard.kde.org/r/125817/ which awaits ship it)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Calendar events are still correctly \
displayed</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/calendar/CMakeLists.txt <span style="color: \
grey">(40ead911ad5208cae5dbe5333d227f9f8a0d9154)</span></li>
<li>src/declarativeimports/calendar/calendarplugin.cpp <span style="color: \
grey">(bafe80cf7520a08312abfd1dbd6d4648a6710175)</span></li>
<li>src/declarativeimports/calendar/daysmodel.h <span style="color: \
grey">(a5bdac98627f7efa76bd4afd239469b53e06690b)</span></li>
<li>src/declarativeimports/calendar/daysmodel.cpp <span style="color: \
grey">(2d059a8e8636565adbe52811e602fff37a5eb157)</span></li>
<li>src/declarativeimports/calendar/eventpluginsmanager.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/declarativeimports/calendar/eventpluginsmanager.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/declarativeimports/calendar/qml/MonthView.qml <span style="color: \
grey">(f698934f850ef3a917b9611c9f9a40c369b23f6c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125951/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1849064928901526125==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic