'Re: Review Request 124536: Expose immutable config options in ConfigPropertyMap'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124536: Expose immutable config options in ConfigPropertyMap
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2015-11-03 20:00:45
Message-ID: 20151103200045.24343.74391 () mimi ! kde ! org
[Download RAW message or body]

--===============1987223382222147771==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124536/
-----------------------------------------------------------

(Updated Nov. 3, 2015, 8 nachm.)

Review request for Plasma.

Changes
-------

Use protected constructor

Repository: kdeclarative

Description
-------

This exposes a hash of immutable config options through the "immutables" property. I \
tried adding a Q_INVOKABLE which would be much nicer but me and Dan tried everything \
but couldn't make it work.

Diffs (updated)
-----

  src/kdeclarative/configpropertymap.h f2a22ed 
  src/kdeclarative/configpropertymap.cpp 614d157 

Diff: https://git.reviewboard.kde.org/r/124536/diff/

Testing
-------

Works, I can not grey out immutable config options in Plasma

Thanks,

Kai Uwe Broulik

--===============1987223382222147771==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124536/">https://git.reviewboard.kde.org/r/124536/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Nov. 3, 2015, 8 nachm.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use protected constructor</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This exposes a hash of immutable config options \
through the "immutables" property. I tried adding a Q_INVOKABLE which would be much \
nicer but me and Dan tried everything but couldn't make it work.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works, I can not grey out immutable config options in \
Plasma</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kdeclarative/configpropertymap.h <span style="color: \
grey">(f2a22ed)</span></li>

 <li>src/kdeclarative/configpropertymap.cpp <span style="color: \
grey">(614d157)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124536/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1987223382222147771==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 