[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125811: detect gtk engine
From: "Hrvoje Senjan" <hrvoje.senjan () gmail ! com>
Date: 2015-11-03 17:38:16
Message-ID: 20151103173816.24343.26283 () mimi ! kde ! org
[Download RAW message or body]
--===============0521916576773977193==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125811/#review87948
-----------------------------------------------------------
cmake/FindGTKEngine.cmake (line 17)
<https://git.reviewboard.kde.org/r/125811/#comment60331>
KDE_INSTALL_FULL_LIBDIR rather?
- Hrvoje Senjan
On Oct. 27, 2015, 10:22 a.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125811/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 10:22 a.m.)
>
>
> Review request for Plasma and David Edmundson.
>
>
> Repository: breeze-gtk
>
>
> Description
> -------
>
> first attempt at detecting gtk 2 pixmap engine as runtime dependency
>
> but it doesn't work if you set cmake path to different from gtk engine
>
> and I don't know if it works on distros that use /usr/lib64/ rather than \
> /usr/lib/x86_86-linux-gnu
>
> Diffs
> -----
>
> CMakeLists.txt 9d7b7a7
> cmake/FindGTKEngine.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/125811/diff/
>
>
> Testing
> -------
>
> works for me unless I install outwith /usr/
>
>
> Thanks,
>
> Jonathan Riddell
>
>
--===============0521916576773977193==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125811/">https://git.reviewboard.kde.org/r/125811/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125811/diff/3/?file=412976#file412976line17" \
style="color: black; font-weight: bold; text-decoration: \
underline;">cmake/FindGTKEngine.cmake</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">17</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="o">${</span><span class="nv">CMAKE_INSTALL_PREFIX</span><span \
class="o">}</span><span class="s">/</span><span class="o">${</span><span \
class="nv">LIB_INSTALL_DIR</span><span class="o">}</span><span \
class="s">/gtk-2.0/</span><span class="o">${</span><span class="nv">_ver</span><span \
class="o">}</span><span class="s">.0/engines</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">KDE_INSTALL_FULL_LIBDIR rather?</p></pre> </div>
</div>
<br />
<p>- Hrvoje Senjan</p>
<br />
<p>On October 27th, 2015, 10:22 a.m. CET, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and David Edmundson.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated Oct. 27, 2015, 10:22 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze-gtk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">first attempt at detecting gtk 2 pixmap engine as \
runtime dependency</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">but it doesn't work if you set cmake \
path to different from gtk engine</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">and I don't know if it \
works on distros that use /usr/lib64/ rather than /usr/lib/x86_86-linux-gnu</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">works for me unless I install outwith /usr/</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(9d7b7a7)</span></li>
<li>cmake/FindGTKEngine.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125811/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0521916576773977193==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic