'Re: Review Request 125927: Unbox QJSValue in config property map'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 125927: Unbox QJSValue in config property map
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2015-11-03 12:59:59
Message-ID: 20151103125959.24343.20708 () mimi ! kde ! org
[Download RAW message or body]

--===============5611177811952472781==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125927/
-----------------------------------------------------------

(Updated Nov. 3, 2015, 12:59 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit f2c9db6b770cc7e036247790dfc70da721a0570e by David Edmundson to \
branch master.

Repository: kdeclarative

Description
-------

Currently if one saves a QJSValue into the property map we save the
correct real value, but the propertymap still holds the data as a
QJSValue when retrieved.

This causes an error if a property map is moved between engines as a
QJSValue can only be in one. This can be seen in the system tray where
you can't configure entries on the first load.

By using the updateValue we can intercept updates QML and the property
map making sure only real datatypes are stored in our map.

Diffs
-----

  src/kdeclarative/configpropertymap.h 21a10fcb56c2929fcb43a3387566c101aa16e90f 
  src/kdeclarative/configpropertymap.cpp 93c49a3b1f5929a85754e30704821a36717d4f5d 

Diff: https://git.reviewboard.kde.org/r/125927/diff/

Testing
-------

plasmoidviewer -a org.kde.plasma.systemtray - can conifgure entries \o/

Thanks,

David Edmundson

--===============5611177811952472781==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125927/">https://git.reviewboard.kde.org/r/125927/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Nov. 3, 2015, 12:59 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit f2c9db6b770cc7e036247790dfc70da721a0570e by David \
Edmundson to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currently if one saves a QJSValue into the property \
map we save the correct real value, but the propertymap still holds the data as a
QJSValue when retrieved.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This causes an error if a property map is moved \
between engines as a QJSValue can only be in one. This can be seen in the system tray \
where you can't configure entries on the first load.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">By using the updateValue we can intercept updates QML \
and the property map making sure only real datatypes are stored in our map.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">plasmoidviewer -a org.kde.plasma.systemtray - can \
conifgure entries \o/</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kdeclarative/configpropertymap.h <span style="color: \
grey">(21a10fcb56c2929fcb43a3387566c101aa16e90f)</span></li>

 <li>src/kdeclarative/configpropertymap.cpp <span style="color: \
grey">(93c49a3b1f5929a85754e30704821a36717d4f5d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125927/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5611177811952472781==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 