[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125871: WIP: task geometries to wayland for minimize effect
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2015-11-03 10:13:46
Message-ID: 20151103101346.24343.49492 () mimi ! kde ! org
[Download RAW message or body]
--===============8210500970481541151==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125871/#review87912
-----------------------------------------------------------
autotests/client/test_wayland_windowmanagement.cpp (line 137)
<https://git.reviewboard.kde.org/r/125871/#comment60313>
nitpick
src/client/plasmawindowmanagement.h (line 242)
<https://git.reviewboard.kde.org/r/125871/#comment60309>
@since 5.5
src/client/plasmawindowmodel.h (line 120)
<https://git.reviewboard.kde.org/r/125871/#comment60310>
I guess you wanted to add something here?
src/client/protocols/plasma-window-management.xml (line 116)
<https://git.reviewboard.kde.org/r/125871/#comment60311>
just some thought: should we make it a more general way and use wl_surface? This \
would probably make it more future compatible in case we want ways which don't have a \
plasma surface in future.
src/server/plasmawindowmanagement_interface.h (line 109)
<https://git.reviewboard.kde.org/r/125871/#comment60312>
a const signal?
- Martin Gräßlin
On Nov. 3, 2015, 11:08 a.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125871/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 11:08 a.m.)
>
>
> Review request for kwin and Plasma.
>
>
> Repository: kwayland
>
>
> Description
> -------
>
> this exposes the geometry of taskbar entries in plasma-windowmanagement, in order \
> to make the minimize effects possible. unlike on X11, it takes relative positions \
> and it has one geometry per panel, making possible to have multiple taskbars \
> working.
> however this is still not completely exposed, as internally kwin has still only one \
> geometry, it will need a change in kwin itself (suggestions welcome) probably the \
> rotocol will need also a minimizeTo function that takes the panel as argument.
> another thing completely missing is tests: unfortunately the whole \
> plasma-windowmanagement doesn't have any autotest yet :/
>
> Diffs
> -----
>
> autotests/client/CMakeLists.txt 1556c47
> autotests/client/test_wayland_windowmanagement.cpp PRE-CREATION
> src/client/plasmawindowmanagement.h abd8fa6
> src/client/plasmawindowmanagement.cpp 1f9674c
> src/client/plasmawindowmodel.h 5a6aac4
> src/client/plasmawindowmodel.cpp 355ef53
> src/client/protocols/plasma-window-management.xml ca6a7cc
> src/server/plasmashell_interface.h 9db3f52
> src/server/plasmashell_interface.cpp d29d7bc
> src/server/plasmawindowmanagement_interface.h 6ccc22e
> src/server/plasmawindowmanagement_interface.cpp ad714a5
>
> Diff: https://git.reviewboard.kde.org/r/125871/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
--===============8210500970481541151==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125871/">https://git.reviewboard.kde.org/r/125871/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125871/diff/7/?file=414551#file414551line137" \
style="color: black; font-weight: bold; text-decoration: \
underline;">autotests/client/test_wayland_windowmanagement.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 7)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">137</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="ew"> </span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">nitpick</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125871/diff/7/?file=414552#file414552line242" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/client/plasmawindowmanagement.h</a> <span style="font-weight: \
normal;">
(Diff revision 7)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">242</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> */</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">@since 5.5</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125871/diff/7/?file=414554#file414554line120" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/client/plasmawindowmodel.h</a> <span style="font-weight: normal;">
(Diff revision 7)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">120</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> *<span class="ew"> </span></span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
guess you wanted to add something here?</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125871/diff/7/?file=414556#file414556line116" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/client/protocols/plasma-window-management.xml</a> <span \
style="font-weight: normal;">
(Diff revision 7)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">116</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nt"><arg</span> <span class="na">name=</span><span \
class="s">"panel"</span> <span class="na">type=</span><span \
class="s">"object"</span> <span class="na">interface=</span><span \
class="s">"org_kde_plasma_surface"</span><span \
class="nt">/></span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">just \
some thought: should we make it a more general way and use wl_surface? This would \
probably make it more future compatible in case we want ways which don't have a \
plasma surface in future.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125871/diff/7/?file=414559#file414559line109" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/server/plasmawindowmanagement_interface.h</a> <span \
style="font-weight: normal;">
(Diff revision 7)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">Q_SIGNALS:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">109</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QRect</span> <span class="n">minimizedGeometriesChanged</span><span \
class="p">()</span> <span class="k">const</span><span class="p">;</span></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">a \
const signal?</p></pre> </div>
</div>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On November 3rd, 2015, 11:08 a.m. CET, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Nov. 3, 2015, 11:08 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwayland
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this exposes the geometry of taskbar entries in \
plasma-windowmanagement, in order to make the minimize effects possible. unlike on \
X11, it takes relative positions and it has one geometry per panel, making possible \
to have multiple taskbars working.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">however this is still \
not completely exposed, as internally kwin has still only one geometry, it will need \
a change in kwin itself (suggestions welcome) probably the rotocol will need also a \
minimizeTo function that takes the panel as argument.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">another thing completely missing is tests: unfortunately the whole \
plasma-windowmanagement doesn't have any autotest yet :/</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/client/CMakeLists.txt <span style="color: grey">(1556c47)</span></li>
<li>autotests/client/test_wayland_windowmanagement.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/client/plasmawindowmanagement.h <span style="color: \
grey">(abd8fa6)</span></li>
<li>src/client/plasmawindowmanagement.cpp <span style="color: \
grey">(1f9674c)</span></li>
<li>src/client/plasmawindowmodel.h <span style="color: grey">(5a6aac4)</span></li>
<li>src/client/plasmawindowmodel.cpp <span style="color: grey">(355ef53)</span></li>
<li>src/client/protocols/plasma-window-management.xml <span style="color: \
grey">(ca6a7cc)</span></li>
<li>src/server/plasmashell_interface.h <span style="color: \
grey">(9db3f52)</span></li>
<li>src/server/plasmashell_interface.cpp <span style="color: \
grey">(d29d7bc)</span></li>
<li>src/server/plasmawindowmanagement_interface.h <span style="color: \
grey">(6ccc22e)</span></li>
<li>src/server/plasmawindowmanagement_interface.cpp <span style="color: \
grey">(ad714a5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125871/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8210500970481541151==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic