[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125926: [Image Wallpaper] Take into account orientation
From: "Marco Martin" <notmart () gmail ! com>
Date: 2015-11-03 9:53:30
Message-ID: 20151103095330.24343.20967 () mimi ! kde ! org
[Download RAW message or body]
--===============1640436761293824371==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125926/#review87911
-----------------------------------------------------------
wallpapers/image/image.cpp (line 199)
<https://git.reviewboard.kde.org/r/125926/#comment60308>
how does it behave with images rotated via exif info?
- Marco Martin
On Nov. 2, 2015, 9:27 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125926/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 9:27 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 352555
> https://bugs.kde.org/show_bug.cgi?id=352555
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> The distance method only cares for a match in terms of pixel numbers, not the \
> actual orientation.
>
> Diffs
> -----
>
> wallpapers/image/image.cpp 1b8d2dd
>
> Diff: https://git.reviewboard.kde.org/r/125926/diff/
>
>
> Testing
> -------
>
> Placed a 1440x2560 picture in my image package, it used to get picked and \
> stretched, not it properly takes the 2560x1440 image consistently, or if not \
> present, fall back to a different resolution image.
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============1640436761293824371==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125926/">https://git.reviewboard.kde.org/r/125926/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125926/diff/1/?file=414452#file414452line199" \
style="color: black; font-weight: bold; text-decoration: \
underline;">wallpapers/image/image.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Image::findPreferedImageInPackage(KPackage::Package &package)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">199</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Qt</span><span class="o">::</span><span class="n">Orientation</span> <span \
class="n">candidateOrientation</span> <span class="o">=</span> <span \
class="p">(</span><span class="n">candidate</span><span class="p">.</span><span \
class="n">height</span><span class="p">()</span> <span class="o">></span> <span \
class="n">candidate</span><span class="p">.</span><span class="n">width</span><span \
class="p">()</span> <span class="o">?</span> <span class="n">Qt</span><span \
class="o">::</span><span class="nl">Vertical</span> <span class="p">:</span> <span \
class="n">Qt</span><span class="o">::</span><span class="n">Horizontal</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">how \
does it behave with images rotated via exif info?</p></pre> </div>
</div>
<br />
<p>- Marco Martin</p>
<br />
<p>On November 2nd, 2015, 9:27 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Nov. 2, 2015, 9:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=352555">352555</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The distance method only cares for a match in terms of \
pixel numbers, not the actual orientation.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Placed a 1440x2560 picture in my image package, it \
used to get picked and stretched, not it properly takes the 2560x1440 image \
consistently, or if not present, fall back to a different resolution image.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>wallpapers/image/image.cpp <span style="color: grey">(1b8d2dd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125926/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1640436761293824371==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic