[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125898: [Clipboard plasmoid] Fade out text where buttons are
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2015-11-02 8:11:43
Message-ID: 20151102081143.7259.57498 () mimi ! kde ! org
[Download RAW message or body]
--===============4880138330004635256==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125898/#review87850
-----------------------------------------------------------
Thanks for looking into it! I'm not experienced enough to do an actual review, though \
;-)
- Martin Gräßlin
On Nov. 1, 2015, 2:35 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125898/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2015, 2:35 p.m.)
>
>
> Review request for Plasma, KDE Usability and Martin Gräßlin.
>
>
> Bugs: 354602
> https://bugs.kde.org/show_bug.cgi?id=354602
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This avoids the buttons from blending in with the text making it look ugly.
>
> This could allow us to use flat ToolButtons again since four round things in a row \
> look strange imho.
>
> Diffs
> -----
>
> applets/clipboard/contents/ui/ClipboardItemDelegate.qml b263656
>
> Diff: https://git.reviewboard.kde.org/r/125898/diff/
>
>
> Testing
> -------
>
> Works
>
>
> File Attachments
> ----------------
>
> Hovered item
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/b4fb7d52-90fe-4954-a1c0-462a86c31f4a__klipperlinebreaks3.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============4880138330004635256==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125898/">https://git.reviewboard.kde.org/r/125898/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks for looking into it! I'm not experienced enough to do an actual \
review, though ;-)</p></pre> <br />
<p>- Martin Gräßlin</p>
<br />
<p>On November 1st, 2015, 2:35 p.m. CET, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, KDE Usability and Martin Gräßlin.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Nov. 1, 2015, 2:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=354602">354602</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This avoids the buttons from blending in with the text \
making it look ugly.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This could allow us to use flat \
ToolButtons again since four round things in a row look strange imho.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/clipboard/contents/ui/ClipboardItemDelegate.qml <span style="color: \
grey">(b263656)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125898/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/b4fb7d52-90fe-4954-a1c0-462a86c31f4a__klipperlinebreaks3.png">Hovered \
item</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4880138330004635256==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic