[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125873: preliminar support for task geometries in wayland
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2015-11-02 7:55:49
Message-ID: 20151102075549.7259.93372 () mimi ! kde ! org
[Download RAW message or body]
--===============7476833405959165752==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Oct. 30, 2015, 5:52 p.m., Thomas Lübking wrote:
> > shell_client.cpp, line 412
> > <https://git.reviewboard.kde.org/r/125873/diff/5/?file=413725#file413725line412>
> >
> > should the panel also be tested for being on the same screen (ie. same screen \
> > takes precedence over closer, but other screen)?
>
> Marco Martin wrote:
> yep, good idea absolutely :)
>
> are the screens of ShellClient and of the PlasmaShellSurface accessible from there?
yes, there's a int screen() const available and also a bool isOnScreen(int) const. \
The isOnScreen also returns true if the window overlaps. So I'd rather go for \
comparing the result of screen(). That's all on Toplevel, PlasmaShellSurface doesn't \
have a screen, but you can get the ShellClient for the PlasmaShellSurface.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125873/#review87753
-----------------------------------------------------------
On Oct. 30, 2015, 6:42 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125873/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2015, 6:42 p.m.)
>
>
> Review request for kwin and Plasma.
>
>
> Repository: kwin
>
>
> Description
> -------
>
> make the minimize effect work by reading taskGeometry from plasmawindowmanagement \
> and returning as iconGeometry().
> It still supports a single taskbar as on x11. the architecture will have to change \
> somehow to allow to know from where panel we want to minimize (or if not secified \
> searching for the nearest panel) suggestions welcome :)
>
>
> Diffs
> -----
>
> abstract_client.h 128c141
> client.h f22e690
> shell_client.h fee22c4
> shell_client.cpp 79a1ac5
>
> Diff: https://git.reviewboard.kde.org/r/125873/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
--===============7476833405959165752==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125873/">https://git.reviewboard.kde.org/r/125873/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 30th, 2015, 5:52 p.m. CET, <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125873/diff/5/?file=413725#file413725line412" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shell_client.cpp</a> <span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">412</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">candidatePanel</span> <span class="o">=</span> <span \
class="n">i</span><span class="p">.</span><span class="n">key</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">should the panel also be tested for being on the same screen (ie. same \
screen takes precedence over closer, but other screen)?</p></pre> </blockquote>
<p>On October 30th, 2015, 6:41 p.m. CET, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yep, \
good idea absolutely :)</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">are the screens of ShellClient and of \
the PlasmaShellSurface accessible from there?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">yes, there's a int screen() const available and also a bool isOnScreen(int) \
const. The isOnScreen also returns true if the window overlaps. So I'd rather go for \
comparing the result of screen(). That's all on Toplevel, PlasmaShellSurface doesn't \
have a screen, but you can get the ShellClient for the PlasmaShellSurface.</p></pre> \
<br />
<p>- Martin</p>
<br />
<p>On October 30th, 2015, 6:42 p.m. CET, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Oct. 30, 2015, 6:42 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">make the minimize effect work by reading taskGeometry \
from plasmawindowmanagement and returning as iconGeometry().</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It \
still supports a single taskbar as on x11. the architecture will have to change \
somehow to allow to know from where panel we want to minimize (or if not secified \
searching for the nearest panel) suggestions welcome :)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>abstract_client.h <span style="color: grey">(128c141)</span></li>
<li>client.h <span style="color: grey">(f22e690)</span></li>
<li>shell_client.h <span style="color: grey">(fee22c4)</span></li>
<li>shell_client.cpp <span style="color: grey">(79a1ac5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125873/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7476833405959165752==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic