'Re: Review Request 125886: drkonqi: Drop KF5::WebKit dependency'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 125886: drkonqi: Drop KF5::WebKit dependency
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2015-11-02 7:48:38
Message-ID: 20151102074838.7259.81411 () mimi ! kde ! org
[Download RAW message or body]

--===============8346578554898949633==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125886/#review87843
-----------------------------------------------------------

Ship it!

Nice work and much less impact than I would have expected when I read the review \
title!

Completely unrelated question to Plasma team: why is drkonqi still in \
plasma-workspace?

- Martin Gräßlin

On Oct. 31, 2015, 11:54 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125886/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2015, 11:54 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Replace KWebView with QTextBrowser in unhandled bugzilla error dialog.
> KWebView is not used to load a page here, it is just used to display HTML with \
> setHtml (without baseUrl) so any external URLs (stylesheets, images, ...) are not \
> resolved. Replacing it with QTextBrowser should provide similar rendering.
> 
> 
> Diffs
> -----
> 
> CMakeLists.txt 50091ea 
> drkonqi/CMakeLists.txt 339b475 
> drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp b6beea3 
> 
> Diff: https://git.reviewboard.kde.org/r/125886/diff/
> 
> 
> Testing
> -------
> 
> Made sure it builds, no idea how to trigger the dialog.
> 
> 
> Thanks,
> 
> David Rosca
> 
> 

--===============8346578554898949633==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125886/">https://git.reviewboard.kde.org/r/125886/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Nice \
work and much less impact than I would have expected when I read the review \
title!</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Completely unrelated question to Plasma team: why is \
drkonqi still in plasma-workspace?</p></pre>  <br />

<p>- Martin Gräßlin</p>

<br />
<p>On October 31st, 2015, 11:54 a.m. CET, David Rosca wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Rosca.</div>

<p style="color: grey;"><i>Updated Oct. 31, 2015, 11:54 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Replace KWebView with QTextBrowser in unhandled \
bugzilla error dialog. KWebView is not used to load a page here, it is just used to \
display HTML with setHtml (without baseUrl) so any external URLs (stylesheets, \
images, ...) are not resolved. Replacing it with QTextBrowser should provide similar \
rendering.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Made sure it builds, no idea how to trigger the \
dialog.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(50091ea)</span></li>

 <li>drkonqi/CMakeLists.txt <span style="color: grey">(339b475)</span></li>

 <li>drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp <span \
style="color: grey">(b6beea3)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125886/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8346578554898949633==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 