'Re: Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2015-10-31 15:39:02
Message-ID: 20151031153902.19145.75220 () mimi ! kde ! org
[Download RAW message or body]

--===============5958913369452435274==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125891/#review87777
-----------------------------------------------------------

I'm not sure, perhaps add Usability.
One thing I would like, though, is the entire header area being scrollable rather \
than the width-changing label. Also please make sure it doesn't break the \
MultiPointTouchArea.

- Kai Uwe Broulik

On Okt. 31, 2015, 2:59 nachm., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125891/
> -----------------------------------------------------------
> 
> (Updated Okt. 31, 2015, 2:59 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Allow to scroll navigate back/forward in DaysCalendar in the entire DaysCalendar \
> component, not just on header label. 
> 
> Diffs
> -----
> 
> src/declarativeimports/calendar/qml/DaysCalendar.qml a1d84d4 
> 
> Diff: https://git.reviewboard.kde.org/r/125891/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Rosca
> 
> 

--===============5958913369452435274==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125891/">https://git.reviewboard.kde.org/r/125891/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
not sure, perhaps add Usability. One thing I would like, though, is the entire header \
area being scrollable rather than the width-changing label. Also please make sure it \
doesn't break the MultiPointTouchArea.</p></pre>  <br />

<p>- Kai Uwe Broulik</p>

<br />
<p>On Oktober 31st, 2015, 2:59 nachm. UTC, David Rosca wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Rosca.</div>

<p style="color: grey;"><i>Updated Okt. 31, 2015, 2:59 nachm.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Allow to scroll navigate back/forward in DaysCalendar \
in the entire DaysCalendar component, not just on header label.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/calendar/qml/DaysCalendar.qml <span style="color: \
grey">(a1d84d4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125891/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5958913369452435274==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 