From kde-panel-devel Sat Oct 31 15:29:59 2015 From: "Kai Uwe Broulik" Date: Sat, 31 Oct 2015 15:29:59 +0000 To: kde-panel-devel Subject: Re: Review Request 125895: [plasmaengineexplorer] Don't crash on invalid plugininfo Message-Id: <20151031152959.19145.65733 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=144630541128212 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3659333623290526617==" --===============3659333623290526617== Content-Type: multipart/alternative; boundary="===============2199499777340075403==" --===============2199499777340075403== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125895/ ----------------------------------------------------------- (Updated Oct. 31, 2015, 3:29 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Changes ------- Submitted with commit e3ed62cf9f44fb16adb7bfe8e347472757e2ae18 by Kai Uwe Broulik to branch Plasma/5.4. Repository: plasma-sdk Description ------- Some engines (eg. mpris) have invalid plugininfo causing plasmaengineexplorer to crash Diffs ----- engineexplorer/engineexplorer.cpp 31525ee Diff: https://git.reviewboard.kde.org/r/125895/diff/ Testing ------- Doesn't crash anymore Thanks, Kai Uwe Broulik --===============2199499777340075403== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125895/

This change has been marked as submitted.

Review request for Plasma.
By Kai Uwe Broulik.

Updated Oct. 31, 2015, 3:29 p.m.

Changes

Submitted with commit e3ed62cf9f44fb16adb7bfe8e347472757e2ae18 by Kai Uwe Broulik to branch Plasma/5.4.
Repository: plasma-sdk

Description 

Some engines (eg. mpris) have invalid plugininfo causing plasmaengineexplorer to crash

Testing 

Doesn't crash anymore

Diffs

  • engineexplorer/engineexplorer.cpp (31525ee)

View Diff
--===============2199499777340075403==-- --===============3659333623290526617== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============3659333623290526617==--