From kde-panel-devel Sat Oct 31 10:54:29 2015 From: "David Rosca" Date: Sat, 31 Oct 2015 10:54:29 +0000 To: kde-panel-devel Subject: Review Request 125886: drkonqi: Drop KF5::WebKit dependency Message-Id: <20151031105429.19145.47834 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=144628889725315 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2699320471766159965==" --===============2699320471766159965== Content-Type: multipart/alternative; boundary="===============3642581041135930857==" --===============3642581041135930857== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125886/ ----------------------------------------------------------- Review request for Plasma. Repository: plasma-workspace Description ------- Replace KWebView with QTextBrowser in unhandled bugzilla error dialog. KWebView is not used to load a page here, it is just used to display HTML with setHtml (without baseUrl) so any external URLs (stylesheets, images, ...) are not resolved. Replacing it with QTextBrowser should provide similar rendering. Diffs ----- CMakeLists.txt 50091ea drkonqi/CMakeLists.txt 339b475 drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp b6beea3 Diff: https://git.reviewboard.kde.org/r/125886/diff/ Testing ------- Made sure it builds, no idea how to trigger the dialog. Thanks, David Rosca --===============3642581041135930857== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125886/

Review request for Plasma.

By David Rosca.

Repository: plasma-workspace

Description

Replace KWebView with QTextBrowser in unhandled bugzilla error dialog. KWebView is not used to load a page here, it is just used to display HTML with setHtml (without baseUrl) so any external URLs (stylesheets, images, ...) are not resolved. Replacing it with QTextBrowser should provide similar rendering.

Testing

Made sure it builds, no idea how to trigger the dialog.

Diffs

CMakeLists.txt (50091ea)
drkonqi/CMakeLists.txt (339b475)
drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp (b6beea3)

View Diff

--===============3642581041135930857==-- --===============2699320471766159965== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============2699320471766159965==--