[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request 125887: Allow to build ProcessUI without QtWebKitWidgets
From: "David Rosca" <nowrep () gmail ! com>
Date: 2015-10-31 10:54:25
Message-ID: 20151031105425.19145.98482 () mimi ! kde ! org
[Download RAW message or body]
--===============8189503299152534787==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125887/
-----------------------------------------------------------
Review request for Plasma.
Repository: libksysguard
Description
-------
When building without QtWebKitWidgets, the Detailed Memory Information dialog is not \
working (will not be opened at all). This makes plasma-workspace build without \
QtWebKitWidgets as it requires KSysGuardProcessList from ProcessUI.
Diffs
-----
CMakeLists.txt 14d32d9
config-ksysguard.h.cmake d95e1f5
processui/CMakeLists.txt 7f87b85
processui/scripting.h e8b1e3b
processui/scripting.cpp adcb354
Diff: https://git.reviewboard.kde.org/r/125887/diff/
Testing
-------
Builds, clicking on Detailed Memory Information from context menu just does nothing.
Thanks,
David Rosca
--===============8189503299152534787==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125887/">https://git.reviewboard.kde.org/r/125887/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Rosca.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libksysguard
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When building without QtWebKitWidgets, the Detailed \
Memory Information dialog is not working (will not be opened at all). This makes \
plasma-workspace build without QtWebKitWidgets as it requires KSysGuardProcessList \
from ProcessUI.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds, clicking on Detailed Memory Information from \
context menu just does nothing.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(14d32d9)</span></li>
<li>config-ksysguard.h.cmake <span style="color: grey">(d95e1f5)</span></li>
<li>processui/CMakeLists.txt <span style="color: grey">(7f87b85)</span></li>
<li>processui/scripting.h <span style="color: grey">(e8b1e3b)</span></li>
<li>processui/scripting.cpp <span style="color: grey">(adcb354)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125887/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8189503299152534787==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic