--===============6844654543712958273== Content-Type: multipart/alternative; boundary="===============3654700314690444347==" --===============3654700314690444347== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125878/ ----------------------------------------------------------- (Updated Oct. 30, 2015, 9:06 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma, David Edmundson and David Faure. Changes ------- Submitted with commit 4ca3237c2e07ac035104af5730bd209c18f61fe2 by Takahiro Hashimoto to branch master. Repository: kdeclarative Description ------- After my commit 1c3f42afe17cc090372eaf45647d71495de12c19, view's initialiSize value is lost (remaining 0,0 in spite of item's size). It should be set by item's size for some reusing purpose (with initialSize() getter) Sorry again my bad commit :( Diffs ----- src/quickaddons/quickviewsharedengine.cpp 323cf92 Diff: https://git.reviewboard.kde.org/r/125878/diff/ Testing ------- build and run test kenya888@xps13 ~/devel/kf5/build/frameworks/kdeclarative $ ninja test [1/1] Running tests... Test project /home/kenya888/devel/kf5/build/frameworks/kdeclarative Start 1: fullmodelaccesstest 1/2 Test #1: fullmodelaccesstest .............. Passed 0.05 sec Start 2: quickviewsharedengine 2/2 Test #2: quickviewsharedengine ............ Passed 0.39 sec 100% tests passed, 0 tests failed out of 2 Total Test time (real) = 0.44 sec ------ confirmed ksplashqml works well which use QuickViewSharedEngine. Thanks, Takahiro Hashimoto --===============3654700314690444347== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125878/

This change has been marked as submitted.

Review request for Plasma, David Edmundson and David Faure.

By Takahiro Hashimoto.

Updated Oct. 30, 2015, 9:06 p.m.

Changes

Submitted with commit 4ca3237c2e07ac035104af5730bd209c18f61fe2 by Takahiro Hashimoto to branch master.

Repository: kdeclarative

Description

After my commit 1c3f42afe17cc090372eaf45647d71495de12c19, view's initialiSize value is lost (remaining 0,0 in spite of item's size). It should be set by item's size for some reusing purpose (with initialSize() getter) 
Sorry again my bad commit :(

Testing

build and run test

kenya888@xps13 ~/devel/kf5/build/frameworks/kdeclarative $ ninja test [1/1] Running tests... Test project /home/kenya888/devel/kf5/build/frameworks/kdeclarative Start 1: fullmodelaccesstest 1/2 Test #1: fullmodelaccesstest .............. Passed 0.05 sec Start 2: quickviewsharedengine 2/2 Test #2: quickviewsharedengine ............ Passed 0.39 sec

100% tests passed, 0 tests failed out of 2

Total Test time (real) = 0.44 sec

confirmed ksplashqml works well which use QuickViewSharedEngine.

Diffs

src/quickaddons/quickviewsharedengine.cpp (323cf92)

--===============3654700314690444347==-- --===============6844654543712958273== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============6844654543712958273==--