[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125864: Add back the Agenda part of the Calendar
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2015-10-30 19:11:00
Message-ID: 20151030191100.14097.52174 () mimi ! kde ! org
[Download RAW message or body]
--===============5606266414960256840==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125864/
-----------------------------------------------------------
(Updated Oct. 30, 2015, 8:11 p.m.)
Review request for Plasma.
Changes
-------
+ fix issues
+ add time label to the events, see new screenshot
I'm not entirely sure about the offset of the label when there is just one time (the \
todo in the screenshot) but it makes all things with time aligned properly, so I \
dunno. Thoughts?
Repository: plasma-workspace
Description
-------
Adds back the Agenda that was there pre-5.0 with some changes.
It now shows an overview of the given day events/holidays. I'd
like to add a second view at some point that would show you the
selected day by hours but that is much more work and the freeze
is getting closer, so maybe that will have to wait till 5.6.
Diffs (updated)
-----
applets/digital-clock/package/contents/ui/CalendarView.qml b52eb10
Diff: https://git.reviewboard.kde.org/r/125864/diff/
Testing
-------
Selecting a day correctly changes the date in the agenda and correctly displays the \
events of the day.
Event removal/modification also removes/modifies it from the agenda.
File Attachments (updated)
----------------
Current look in Breeze
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/5485250c-8d20-409e-8a5b-0eda7a9d7b8d__snapshot29.png
Multiple same-day events
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/d453a01e-f9cf-4da3-8f6a-fac5aa6aadf5__snapshot18.png
New screenshot
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/30/c75fed5e-02fd-4906-8bd9-726f0fc54ce8__snapshot30.png
Thanks,
Martin Klapetek
--===============5606266414960256840==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125864/">https://git.reviewboard.kde.org/r/125864/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Oct. 30, 2015, 8:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">+ fix issues + add time label to the events, see new screenshot
I'm not entirely sure about the offset of the label when there is just one time \
(the todo in the screenshot) but it makes all things with time aligned properly, so I \
dunno. Thoughts?</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Adds back the Agenda that was there pre-5.0 with some \
changes.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It now shows an overview of the given day \
events/holidays. I'd like to add a second view at some point that would show you the
selected day by hours but that is much more work and the freeze
is getting closer, so maybe that will have to wait till 5.6.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Selecting a day correctly changes the date in the \
agenda and correctly displays the events of the day.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Event \
removal/modification also removes/modifies it from the agenda.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>applets/digital-clock/package/contents/ui/CalendarView.qml <span style="color: \
grey">(b52eb10)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125864/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
(updated)</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/5485250c-8d20-409e-8a5b-0eda7a9d7b8d__snapshot29.png">Current \
look in Breeze</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/d453a01e-f9cf-4da3-8f6a-fac5aa6aadf5__snapshot18.png">Multiple \
same-day events</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/30/c75fed5e-02fd-4906-8bd9-726f0fc54ce8__snapshot30.png">New \
screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5606266414960256840==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic