--===============5313350959508175218== Content-Type: multipart/alternative; boundary="===============7711955044459696018==" --===============7711955044459696018== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On Oct. 30, 2015, 7:51 a.m., Martin Gräßlin wrote: > > CMakeLists.txt, line 31 > > > > > > Should it be a required dep? I think it wasn't in 4.x? And reading the code it should be easy to have it optional as we just need to make the one add_subdirectory call conditional. Yeah, good point, it shouldn't be. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125862/#review87715 ----------------------------------------------------------- On Oct. 29, 2015, 5:01 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125862/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2015, 5:01 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This is very simple for now as there is no configuration > yet, so it just takes the default region (your locale) > and shows holidays from that. > > Obviously this needs a config to set up which regions > you want to show in there, but this is a start. > > > Diffs > ----- > > CMakeLists.txt 50091ea > plasmacalendarintegration/CMakeLists.txt PRE-CREATION > plasmacalendarintegration/holidaysevents.h PRE-CREATION > plasmacalendarintegration/holidaysevents.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125862/diff/ > > > Testing > ------- > > Holidays are properly listed in calendar applet. > > > Thanks, > > Martin Klapetek > > --===============7711955044459696018== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125862/

On October 30th, 2015, 7:51 a.m. CET, Martin Gräßlin wrote:

CMakeLists.txt (Diff revision 1)
		31	find_package(KF5Holidays REQUIRED)

Should it be a required dep? I think it wasn't in 4.x? And reading the code it should be easy to have it optional as we just need to make the one add_subdirectory call conditional.

Yeah, good point, it shouldn't be.

- Martin

On October 29th, 2015, 5:01 p.m. CET, Martin Klapetek wrote:

Review request for Plasma.

By Martin Klapetek.

Updated Oct. 29, 2015, 5:01 p.m.

Repository: plasma-workspace

Description

This is very simple for now as there is no configuration yet, so it just takes the default region (your locale) and shows holidays from that.

Obviously this needs a config to set up which regions you want to show in there, but this is a start.

Testing

Holidays are properly listed in calendar applet.

Diffs

CMakeLists.txt (50091ea)
plasmacalendarintegration/CMakeLists.txt (PRE-CREATION)
plasmacalendarintegration/holidaysevents.h (PRE-CREATION)
plasmacalendarintegration/holidaysevents.cpp (PRE-CREATION)

--===============7711955044459696018==-- --===============5313350959508175218== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============5313350959508175218==--